helpy4/Minecraft-Console-Client
1
0
Fork 0
mirror of https://github.com/MCCTeam/Minecraft-Console-Client synced 2026-08-15 13:04:36 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Address code review: eliminate unnecessary allocation in progress-only updates

Browse source 
Agent-Logs-Url: https://github.com/MCCTeam/Minecraft-Console-Client/sessions/9db483a8-4a5f-47b1-a6f4-30b6e39075bd

Co-authored-by: milutinke <441903+milutinke@users.noreply.github.com>
This commit is contained in:
copilot-swe-agent[bot] 2026-03-29 20:27:12 +00:00
parent 65ef3dde6b
commit 7b3e5ee492
1 changed files with 2 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

5
MinecraftClient/Protocol/Handlers/Protocol18.cs
View file

@ -3283,14 +3283,13 @@ namespace MinecraftClient.Protocol.Handlers
}
// Also build Achievement records for progress-only updates (no definition change)
var progressOnly = new List<Achievement>();
foreach (var (id, criteria) in progressMap)
{
if (!addedDefinitions.ContainsKey(id))
progressOnly.Add(new Achievement(id, null, null, AchievementType.Task, false, false, [], criteria));
added.Add(new Achievement(id, null, null, AchievementType.Task, false, false, [], criteria));
}
handler.OnAchievementsUpdate([.. added, .. progressOnly], removedIds, reset);
handler.OnAchievementsUpdate(added, removedIds, reset);
}
/// <summary>