From 7b3e5ee49215ddc76b5addf7db599e43267f8852 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Sun, 29 Mar 2026 20:27:12 +0000 Subject: [PATCH] Address code review: eliminate unnecessary allocation in progress-only updates Agent-Logs-Url: https://github.com/MCCTeam/Minecraft-Console-Client/sessions/9db483a8-4a5f-47b1-a6f4-30b6e39075bd Co-authored-by: milutinke <441903+milutinke@users.noreply.github.com> --- MinecraftClient/Protocol/Handlers/Protocol18.cs | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/MinecraftClient/Protocol/Handlers/Protocol18.cs b/MinecraftClient/Protocol/Handlers/Protocol18.cs index 2d934561..bb603f9b 100644 --- a/MinecraftClient/Protocol/Handlers/Protocol18.cs +++ b/MinecraftClient/Protocol/Handlers/Protocol18.cs @@ -3283,14 +3283,13 @@ namespace MinecraftClient.Protocol.Handlers } // Also build Achievement records for progress-only updates (no definition change) - var progressOnly = new List(); foreach (var (id, criteria) in progressMap) { if (!addedDefinitions.ContainsKey(id)) - progressOnly.Add(new Achievement(id, null, null, AchievementType.Task, false, false, [], criteria)); + added.Add(new Achievement(id, null, null, AchievementType.Task, false, false, [], criteria)); } - handler.OnAchievementsUpdate([.. added, .. progressOnly], removedIds, reset); + handler.OnAchievementsUpdate(added, removedIds, reset); } ///