mirror of
https://github.com/immich-app/immich
synced 2025-11-14 17:36:12 +00:00
de67d22bc0
I ran into this while testing out <https://github.com/immich-app/immich/pull/19830>. When I add, change, or remove a client certificate under Immich's advanced settings, the change wouldn't take effect until some mysterious point in the future. For example: 1. Add a client certificate. It doesn't get used. 2. Remove certificate. *Now* the client certificate from step 1) is used. 3. Restart application. Now no client certificate is used. This all boils down to some missing `await`s. The user would change the cert, and we'd start asynchronously saving it to the store, and while the save is still happening, [`HttpSSLOptions` pulls the "old" value out of `SSLClientCertStoreVal`](https://github.com/immich-app/immich/blob/v1.136.0/mobile/lib/utils/http_ssl_options.dart#L30). With the appropriate `await`s, this behaves much more sanely. |
||
|---|---|---|
| .. | ||
| asset_list_settings | ||
| asset_viewer_settings | ||
| backup_settings | ||
| beta_sync_settings | ||
| custom_proxy_headers_settings | ||
| networking_settings | ||
| preference_settings | ||
| advanced_settings.dart | ||
| beta_timeline_list_tile.dart | ||
| language_settings.dart | ||
| local_storage_settings.dart | ||
| notification_setting.dart | ||
| settings_button_list_tile.dart | ||
| settings_card.dart | ||
| settings_radio_list_tile.dart | ||
| settings_slider_list_tile.dart | ||
| settings_sub_page_scaffold.dart | ||
| settings_sub_title.dart | ||
| settings_switch_list_tile.dart | ||
| ssl_client_cert_settings.dart | ||