import { UserAdminController } from 'src/controllers/user-admin.controller'; import { UserAdminCreateDto } from 'src/dtos/user.dto'; import { LoggingRepository } from 'src/repositories/logging.repository'; import { UserAdminService } from 'src/services/user-admin.service'; import request from 'supertest'; import { errorDto } from 'test/medium/responses'; import { factory } from 'test/small.factory'; import { automock, ControllerContext, controllerSetup, mockBaseService } from 'test/utils'; describe(UserAdminController.name, () => { let ctx: ControllerContext; const service = mockBaseService(UserAdminService); beforeAll(async () => { ctx = await controllerSetup(UserAdminController, [ { provide: LoggingRepository, useValue: automock(LoggingRepository, { strict: false }) }, { provide: UserAdminService, useValue: service }, ]); return () => ctx.close(); }); beforeEach(() => { service.resetAllMocks(); ctx.reset(); }); describe('POST /admin/users', () => { it('should allow a null pinCode', async () => { await request(ctx.getHttpServer()).post(`/admin/users`).send({ name: 'Test user', email: 'test@immich.cloud', password: 'password', pinCode: null, }); expect(service.create).toHaveBeenCalledWith(expect.objectContaining({ pinCode: null })); }); it('should allow a null avatarColor', async () => { await request(ctx.getHttpServer()).post(`/admin/users`).send({ name: 'Test user', email: 'test@immich.cloud', password: 'password', avatarColor: null, }); expect(service.create).toHaveBeenCalledWith(expect.objectContaining({ avatarColor: null })); }); for (const [key, message] of [ ['password', 'Invalid input: expected string, received null'], ['email', 'Invalid input: expected email, received object'], ['name', 'Invalid input: expected string, received null'], ['shouldChangePassword', 'Invalid input: expected boolean, received null'], ['notify', 'Invalid input: expected boolean, received null'], ] as const) { it(`should not allow null ${key}`, async () => { const { status, body } = await request(ctx.getHttpServer()) .post(`/admin/users`) .set('Authorization', `Bearer token`) .send({ email: 'user@immich.app', password: 'test', name: 'Test User', [key]: null }); expect(status).toBe(400); expect(body).toEqual(errorDto.validationError([{ path: [key], message }])); }); } it(`should not allow decimal quota`, async () => { const dto: UserAdminCreateDto = { email: 'user@immich.app', password: 'test', name: 'Test User', quotaSizeInBytes: 1.2, }; const { status, body } = await request(ctx.getHttpServer()) .post(`/admin/users`) .set('Authorization', `Bearer token`) .send(dto); expect(status).toBe(400); expect(body).toEqual( errorDto.validationError([ { path: ['quotaSizeInBytes'], message: 'Invalid input: expected int, received number' }, ]), ); }); }); describe('PUT /admin/users/:id', () => { it(`should not allow decimal quota`, async () => { const { status, body } = await request(ctx.getHttpServer()) .put(`/admin/users/${factory.uuid()}`) .set('Authorization', `Bearer token`) .send({ quotaSizeInBytes: 1.2 }); expect(status).toBe(400); expect(body).toEqual( errorDto.validationError([ { path: ['quotaSizeInBytes'], message: 'Invalid input: expected int, received number' }, ]), ); }); it('should allow a null pinCode', async () => { const id = factory.uuid(); await request(ctx.getHttpServer()).put(`/admin/users/${id}`).send({ pinCode: null }); expect(service.update).toHaveBeenCalledWith(undefined, id, expect.objectContaining({ pinCode: null })); }); it('should allow a null avatarColor', async () => { const id = factory.uuid(); await request(ctx.getHttpServer()).put(`/admin/users/${id}`).send({ avatarColor: null }); expect(service.update).toHaveBeenCalledWith(undefined, id, expect.objectContaining({ avatarColor: null })); }); for (const [key, message] of [ ['password', 'Invalid input: expected string, received null'], ['email', 'Invalid input: expected email, received object'], ['name', 'Invalid input: expected string, received null'], ['shouldChangePassword', 'Invalid input: expected boolean, received null'], ] as const) { it(`should not allow null ${key}`, async () => { const { status, body } = await request(ctx.getHttpServer()) .put(`/admin/users/${factory.uuid()}`) .set('Authorization', `Bearer token`) .send({ [key]: null }); expect(status).toBe(400); expect(body).toEqual(errorDto.validationError([{ path: [key], message }])); }); } }); });