chore(server,cli,web): housekeeping and stricter code style (#6751)

* add unicorn to eslint

* fix lint errors for cli

* fix merge

* fix album name extraction

* Update cli/src/commands/upload.command.ts

Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>

* es2k23

* use lowercase os

* return undefined album name

* fix bug in asset response dto

* auto fix issues

* fix server code style

* es2022 and formatting

* fix compilation error

* fix test

* fix config load

* fix last lint errors

* set string type

* bump ts

* start work on web

* web formatting

* Fix UUIDParamDto as UUIDParamDto

* fix library service lint

* fix web errors

* fix errors

* formatting

* wip

* lints fixed

* web can now start

* alphabetical package json

* rename error

* chore: clean up

---------

Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
Co-authored-by: Jason Rasmussen <jrasm91@gmail.com>

web/src/lib/components/admin-page/delete-confirm-dialoge.svelte

@@ -14,10 +14,10 @@
   const deleteUser = async () => {
     try {
       const deletedUser = await api.userApi.deleteUser({ id: user.id });
-      if (deletedUser.data.deletedAt != null) {
-        dispatch('success');
-      } else {
+      if (deletedUser.data.deletedAt == undefined) {
         dispatch('fail');
+      } else {
+        dispatch('success');
       }
     } catch (error) {
       handleError(error, 'Unable to delete user');

web/src/lib/components/admin-page/jobs/job-tile.svelte

@@ -18,7 +18,7 @@
   } from '@mdi/js';
 
   export let title: string;
-  export let subtitle: string | undefined = undefined;
+  export let subtitle: string | undefined;
   export let jobCounts: JobCountsDto;
   export let queueStatus: QueueStatusDto;
   export let allowForceCommand = true;

web/src/lib/components/admin-page/jobs/jobs-panel.svelte

@@ -131,12 +131,13 @@
       jobs[jobId] = data;
 
       switch (jobCommand.command) {
-        case JobCommand.Empty:
+        case JobCommand.Empty: {
           notificationController.show({
             message: `Cleared jobs for: ${title}`,
             type: NotificationType.Info,
           });
           break;
+        }
       }
     } catch (error) {
       handleError(error, `Command '${jobCommand.command}' failed for job: ${title}`);

web/src/lib/components/admin-page/restore-dialoge.svelte

@@ -12,7 +12,7 @@
 
   const restoreUser = async () => {
     const restoredUser = await api.userApi.restoreUser({ id: user.id });
-    if (restoredUser.data.deletedAt == null) {
+    if (restoredUser.data.deletedAt == undefined) {
       dispatch('success');
     } else {
       dispatch('fail');

web/src/lib/components/admin-page/settings/admin-settings.svelte

@@ -19,11 +19,7 @@
   const dispatch = createEventDispatcher<{ save: void }>();
 
   const handleReset = async (detail: SettingsEventType['reset']) => {
-    if (detail.default) {
-      await resetToDefault(detail.configKeys);
-    } else {
-      await reset(detail.configKeys);
-    }
+    await (detail.default ? resetToDefault(detail.configKeys) : reset(detail.configKeys));
   };
 
   const handleSave = async (update: Partial<SystemConfigDto>) => {
@@ -47,7 +43,10 @@
 
   const reset = async (configKeys: Array<keyof SystemConfigDto>) => {
     const { data: resetConfig } = await api.systemConfigApi.getConfig();
-    config = configKeys.reduce((acc, key) => ({ ...acc, [key]: resetConfig[key] }), config);
+
+    for (const key of configKeys) {
+      config = { ...config, [key]: resetConfig[key] };
+    }
 
     notificationController.show({
       message: 'Reset settings to the recent saved settings',
@@ -56,7 +55,9 @@
   };
 
   const resetToDefault = async (configKeys: Array<keyof SystemConfigDto>) => {
-    config = configKeys.reduce((acc, key) => ({ ...acc, [key]: defaultConfig[key] }), config);
+    for (const key of configKeys) {
+      config = { ...config, [key]: defaultConfig[key] };
+    }
 
     notificationController.show({
       message: 'Reset settings to default',

web/src/lib/components/admin-page/settings/setting-checkboxes.svelte

@@ -11,11 +11,7 @@
   export let disabled = false;
 
   function handleCheckboxChange(option: string) {
-    if (value.includes(option)) {
-      value = value.filter((item) => item !== option);
-    } else {
-      value = [...value, option];
-    }
+    value = value.includes(option) ? value.filter((item) => item !== option) : [...value, option];
   }
 </script>
 

web/src/lib/components/admin-page/settings/setting-select.svelte

@@ -17,7 +17,7 @@
   const handleChange = (e: Event) => {
     value = (e.target as HTMLInputElement).value;
     if (number) {
-      value = parseInt(value);
+      value = Number.parseInt(value);
     }
     dispatch('select', value);
   };

web/src/lib/components/admin-page/settings/storage-template/storage-template-settings.svelte

@@ -38,7 +38,7 @@
   $: parsedTemplate = () => {
     try {
       return renderTemplate(config.storageTemplate.template);
-    } catch (error) {
+    } catch {
       return 'error';
     }
   };