helpy4/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich synced 2026-08-15 13:03:57 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix(server): broken memories (#23896)
Some checks failed
CLI Build / CLI Publish (push) Has been cancelled
Details
CodeQL / Analyze (push) Has been cancelled
Details
Docker / pre-job (push) Has been cancelled
Details
Docs build / pre-job (push) Has been cancelled
Details
Zizmor / Zizmor (push) Has been cancelled
Details
Manage release PR / bump (push) Has been cancelled
Details
Static Code Analysis / pre-job (push) Has been cancelled
Details
Test / pre-job (push) Has been cancelled
Details
Test / ShellCheck (push) Has been cancelled
Details
Test / OpenAPI Clients (push) Has been cancelled
Details
Test / SQL Schema Checks (push) Has been cancelled
Details
CLI Build / Docker (push) Has been cancelled
Details
Docker / Re-Tag ML (push) Has been cancelled
Details
Docker / Re-Tag Server (push) Has been cancelled
Details
Docker / Build and Push ML (push) Has been cancelled
Details
Docker / Build and Push Server (push) Has been cancelled
Details
Docker / Docker Build & Push Server Success (push) Has been cancelled
Details
Docker / Docker Build & Push ML Success (push) Has been cancelled
Details
Docs build / Docs Build (push) Has been cancelled
Details
Static Code Analysis / Run Dart Code Analysis (push) Has been cancelled
Details
Test / Test & Lint Server (push) Has been cancelled
Details
Test / Unit Test CLI (push) Has been cancelled
Details
Test / Unit Test CLI (Windows) (push) Has been cancelled
Details
Test / Lint Web (push) Has been cancelled
Details
Test / Test Web (push) Has been cancelled
Details
Test / Test i18n (push) Has been cancelled
Details
Test / End-to-End Lint (push) Has been cancelled
Details
Test / Medium Tests (Server) (push) Has been cancelled
Details
Test / End-to-End Tests (Server & CLI) (push) Has been cancelled
Details
Test / End-to-End Tests (Web) (push) Has been cancelled
Details
Test / End-to-End Tests Success (push) Has been cancelled
Details
Test / Unit Test Mobile (push) Has been cancelled
Details
Test / Unit Test ML (push) Has been cancelled
Details
Test / .github Files Formatting (push) Has been cancelled
Details

Browse source
This commit is contained in:
Jason Rasmussen 2025-11-14 11:46:32 -05:00 • committed by GitHub
parent 074fdb2b96
commit f11bfb9581
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 7 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

5
server/src/controllers/memory.controller.spec.ts
View file

@ -24,6 +24,11 @@ describe(MemoryController.name, () => {
await request(ctx.getHttpServer()).get('/memories');
expect(ctx.authenticate).toHaveBeenCalled();
});
it('should not require any parameters', async () => {
await request(ctx.getHttpServer()).get('/memories').query({});
expect(service.search).toHaveBeenCalled();
});
});
describe('POST /memories', () => {

3
server/src/dtos/memory.dto.ts
View file

@ -5,7 +5,7 @@ import { Memory } from 'src/database';
import { AssetResponseDto, mapAsset } from 'src/dtos/asset-response.dto';
import { AuthDto } from 'src/dtos/auth.dto';
import { AssetOrderWithRandom, MemoryType } from 'src/enum';
import { ValidateBoolean, ValidateDate, ValidateEnum, ValidateUUID } from 'src/validation';
import { Optional, ValidateBoolean, ValidateDate, ValidateEnum, ValidateUUID } from 'src/validation';
class MemoryBaseDto {
@ValidateBoolean({ optional: true })
@ -31,6 +31,7 @@ export class MemorySearchDto {
@IsInt()
@IsPositive()
@Type(() => Number)
@Optional()
@ApiProperty({ type: 'integer', description: 'Number of memories to return' })
size?: number;