From 5e37605e6b15a7761709ff547bb4ac3ec4e3615f Mon Sep 17 00:00:00 2001 From: mmomjian <50788000+mmomjian@users.noreply.github.com> Date: Fri, 17 Oct 2025 10:45:47 -0400 Subject: [PATCH 1/4] cleanup i18n, return experimental notation --- i18n/en.json | 9 +++---- .../pages/common/headers_settings.page.dart | 2 +- .../custome_proxy_headers_settings.dart | 27 ------------------- 3 files changed, 5 insertions(+), 33 deletions(-) delete mode 100644 mobile/lib/widgets/settings/custom_proxy_headers_settings/custome_proxy_headers_settings.dart diff --git a/i18n/en.json b/i18n/en.json index d265c9b9d8..3bc207c234 100644 --- a/i18n/en.json +++ b/i18n/en.json @@ -404,11 +404,11 @@ "advanced_settings_prefer_remote_subtitle": "Some devices are painfully slow to load thumbnails from local assets. Activate this setting to load remote images instead.", "advanced_settings_prefer_remote_title": "Prefer remote images", "advanced_settings_proxy_headers_subtitle": "Define proxy headers Immich should send with each network request", - "advanced_settings_proxy_headers_title": "Proxy Headers", + "advanced_settings_proxy_headers_title": "Custom proxy headers (EXPERIMENTAL)", "advanced_settings_readonly_mode_subtitle": "Enables the read-only mode where the photos can be only viewed, things like selecting multiple images, sharing, casting, delete are all disabled. Enable/Disable read-only via user avatar from the main screen", "advanced_settings_readonly_mode_title": "Read-only Mode", "advanced_settings_self_signed_ssl_subtitle": "Skips SSL certificate verification for the server endpoint. Required for self-signed certificates.", - "advanced_settings_self_signed_ssl_title": "Allow self-signed SSL certificates", + "advanced_settings_self_signed_ssl_title": "Allow self-signed SSL certificates (EXPERIMENTAL)", "advanced_settings_sync_remote_deletions_subtitle": "Automatically delete or restore an asset on this device when that action is taken on the web", "advanced_settings_sync_remote_deletions_title": "Sync remote deletions [EXPERIMENTAL]", "advanced_settings_tile_subtitle": "Advanced user's settings", @@ -693,7 +693,7 @@ "client_cert_invalid_msg": "Invalid certificate file or wrong password", "client_cert_remove_msg": "Client certificate is removed", "client_cert_subtitle": "Supports PKCS12 (.p12, .pfx) format only. Certificate Import/Remove is available only before login", - "client_cert_title": "SSL Client Certificate", + "client_cert_title": "SSL Client Certificate (EXPERIMENTAL)", "clockwise": "Сlockwise", "close": "Close", "collapse": "Collapse", @@ -1121,11 +1121,10 @@ "hash_asset": "Hash asset", "hashed_assets": "Hashed assets", "hashing": "Hashing", - "header_settings_add_header_tip": "Add Header", + "header_settings_add_header_tip": "Add header", "header_settings_field_validator_msg": "Value cannot be empty", "header_settings_header_name_input": "Header name", "header_settings_header_value_input": "Header value", - "headers_settings_tile_subtitle": "Define proxy headers the app should send with each network request", "headers_settings_tile_title": "Custom proxy headers", "hi_user": "Hi {name} ({email})", "hide_all_people": "Hide all people", diff --git a/mobile/lib/pages/common/headers_settings.page.dart b/mobile/lib/pages/common/headers_settings.page.dart index 4cf683b4d9..d123e54870 100644 --- a/mobile/lib/pages/common/headers_settings.page.dart +++ b/mobile/lib/pages/common/headers_settings.page.dart @@ -60,7 +60,7 @@ class HeaderSettingsPage extends HookConsumerWidget { return Scaffold( appBar: AppBar( - title: const Text('advanced_settings_proxy_headers_title').tr(), + title: const Text('headers_settings_tile_title').tr(), centerTitle: false, actions: [ IconButton( diff --git a/mobile/lib/widgets/settings/custom_proxy_headers_settings/custome_proxy_headers_settings.dart b/mobile/lib/widgets/settings/custom_proxy_headers_settings/custome_proxy_headers_settings.dart deleted file mode 100644 index f0e248b39d..0000000000 --- a/mobile/lib/widgets/settings/custom_proxy_headers_settings/custome_proxy_headers_settings.dart +++ /dev/null @@ -1,27 +0,0 @@ -import 'package:auto_route/auto_route.dart'; -import 'package:easy_localization/easy_localization.dart'; -import 'package:flutter/material.dart'; -import 'package:immich_mobile/extensions/build_context_extensions.dart'; -import 'package:immich_mobile/extensions/theme_extensions.dart'; -import 'package:immich_mobile/routing/router.dart'; - -class CustomeProxyHeaderSettings extends StatelessWidget { - const CustomeProxyHeaderSettings({super.key}); - - @override - Widget build(BuildContext context) { - return ListTile( - contentPadding: const EdgeInsets.symmetric(horizontal: 20), - dense: true, - title: Text( - "headers_settings_tile_title".tr(), - style: context.textTheme.bodyLarge?.copyWith(fontWeight: FontWeight.w500), - ), - subtitle: Text( - "headers_settings_tile_subtitle".tr(), - style: context.textTheme.bodyMedium?.copyWith(color: context.colorScheme.onSurfaceSecondary), - ), - onTap: () => context.pushRoute(const HeaderSettingsRoute()), - ); - } -} From d269587167c1215618e1d57f258cc8f55375fdb5 Mon Sep 17 00:00:00 2001 From: mmomjian <50788000+mmomjian@users.noreply.github.com> Date: Fri, 17 Oct 2025 10:47:13 -0400 Subject: [PATCH 2/4] add renamed file --- .../custom_proxy_headers_settings.dart | 27 +++++++++++++++++++ 1 file changed, 27 insertions(+) create mode 100644 mobile/lib/widgets/settings/custom_proxy_headers_settings/custom_proxy_headers_settings.dart diff --git a/mobile/lib/widgets/settings/custom_proxy_headers_settings/custom_proxy_headers_settings.dart b/mobile/lib/widgets/settings/custom_proxy_headers_settings/custom_proxy_headers_settings.dart new file mode 100644 index 0000000000..bddad9f2bd --- /dev/null +++ b/mobile/lib/widgets/settings/custom_proxy_headers_settings/custom_proxy_headers_settings.dart @@ -0,0 +1,27 @@ +import 'package:auto_route/auto_route.dart'; +import 'package:easy_localization/easy_localization.dart'; +import 'package:flutter/material.dart'; +import 'package:immich_mobile/extensions/build_context_extensions.dart'; +import 'package:immich_mobile/extensions/theme_extensions.dart'; +import 'package:immich_mobile/routing/router.dart'; + +class CustomeProxyHeaderSettings extends StatelessWidget { + const CustomeProxyHeaderSettings({super.key}); + + @override + Widget build(BuildContext context) { + return ListTile( + contentPadding: const EdgeInsets.symmetric(horizontal: 20), + dense: true, + title: Text( + "advanced_settings_proxy_headers_title".tr(), + style: context.textTheme.bodyLarge?.copyWith(fontWeight: FontWeight.w500), + ), + subtitle: Text( + "advanced_settings_proxy_headers_subtitle".tr(), + style: context.textTheme.bodyMedium?.copyWith(color: context.colorScheme.onSurfaceSecondary), + ), + onTap: () => context.pushRoute(const HeaderSettingsRoute()), + ); + } +} From 931a8b0040430b890d205839f5b6a1b8dff63b80 Mon Sep 17 00:00:00 2001 From: mmomjian <50788000+mmomjian@users.noreply.github.com> Date: Fri, 17 Oct 2025 10:47:32 -0400 Subject: [PATCH 3/4] rename 2 --- mobile/lib/widgets/settings/advanced_settings.dart | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mobile/lib/widgets/settings/advanced_settings.dart b/mobile/lib/widgets/settings/advanced_settings.dart index 7a107b47d8..c48a85d3f2 100644 --- a/mobile/lib/widgets/settings/advanced_settings.dart +++ b/mobile/lib/widgets/settings/advanced_settings.dart @@ -15,7 +15,7 @@ import 'package:immich_mobile/services/app_settings.service.dart'; import 'package:immich_mobile/utils/hooks/app_settings_update_hook.dart'; import 'package:immich_mobile/utils/http_ssl_options.dart'; import 'package:immich_mobile/widgets/settings/beta_timeline_list_tile.dart'; -import 'package:immich_mobile/widgets/settings/custom_proxy_headers_settings/custome_proxy_headers_settings.dart'; +import 'package:immich_mobile/widgets/settings/custom_proxy_headers_settings/custom_proxy_headers_settings.dart'; import 'package:immich_mobile/widgets/settings/local_storage_settings.dart'; import 'package:immich_mobile/widgets/settings/settings_slider_list_tile.dart'; import 'package:immich_mobile/widgets/settings/settings_sub_page_scaffold.dart'; From efe3778de83de8409e4334b6d7754bf1ba13b996 Mon Sep 17 00:00:00 2001 From: mmomjian <50788000+mmomjian@users.noreply.github.com> Date: Fri, 17 Oct 2025 10:52:44 -0400 Subject: [PATCH 4/4] caps --- i18n/en.json | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/i18n/en.json b/i18n/en.json index 3bc207c234..56966e36a9 100644 --- a/i18n/en.json +++ b/i18n/en.json @@ -120,7 +120,7 @@ "library_settings_description": "Manage external library settings", "library_tasks_description": "Scan external libraries for new and/or changed assets", "library_watching_enable_description": "Watch external libraries for file changes", - "library_watching_settings": "Library watching (EXPERIMENTAL)", + "library_watching_settings": "Library watching [EXPERIMENTAL]", "library_watching_settings_description": "Automatically watch for changed files", "logging_enable_description": "Enable logging", "logging_level_description": "When enabled, what log level to use.", @@ -404,11 +404,11 @@ "advanced_settings_prefer_remote_subtitle": "Some devices are painfully slow to load thumbnails from local assets. Activate this setting to load remote images instead.", "advanced_settings_prefer_remote_title": "Prefer remote images", "advanced_settings_proxy_headers_subtitle": "Define proxy headers Immich should send with each network request", - "advanced_settings_proxy_headers_title": "Custom proxy headers (EXPERIMENTAL)", + "advanced_settings_proxy_headers_title": "Custom proxy headers [EXPERIMENTAL]", "advanced_settings_readonly_mode_subtitle": "Enables the read-only mode where the photos can be only viewed, things like selecting multiple images, sharing, casting, delete are all disabled. Enable/Disable read-only via user avatar from the main screen", - "advanced_settings_readonly_mode_title": "Read-only Mode", + "advanced_settings_readonly_mode_title": "Read-only mode", "advanced_settings_self_signed_ssl_subtitle": "Skips SSL certificate verification for the server endpoint. Required for self-signed certificates.", - "advanced_settings_self_signed_ssl_title": "Allow self-signed SSL certificates (EXPERIMENTAL)", + "advanced_settings_self_signed_ssl_title": "Allow self-signed SSL certificates [EXPERIMENTAL]", "advanced_settings_sync_remote_deletions_subtitle": "Automatically delete or restore an asset on this device when that action is taken on the web", "advanced_settings_sync_remote_deletions_title": "Sync remote deletions [EXPERIMENTAL]", "advanced_settings_tile_subtitle": "Advanced user's settings", @@ -692,8 +692,8 @@ "client_cert_import_success_msg": "Client certificate is imported", "client_cert_invalid_msg": "Invalid certificate file or wrong password", "client_cert_remove_msg": "Client certificate is removed", - "client_cert_subtitle": "Supports PKCS12 (.p12, .pfx) format only. Certificate Import/Remove is available only before login", - "client_cert_title": "SSL Client Certificate (EXPERIMENTAL)", + "client_cert_subtitle": "Supports PKCS12 (.p12, .pfx) format only. Certificate import/removal is available only before login", + "client_cert_title": "SSL client certificate [EXPERIMENTAL]", "clockwise": "Сlockwise", "close": "Close", "collapse": "Collapse",