helpy4/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich synced 2025-11-07 17:27:20 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

feat(server): search unknown place (#10866)

Browse source 
* Allow submission of null country

* Update searchAssetBuilder to handle nulls

andWhere({country:null}) produces `"exifInfo"."country" = NULL`. We want
`"exifInfo"."country" IS NULL`, so we have to treat NULL as a special
case

* Allow null country in frontend

* Make the query code a bit more straightforward

* Remove unused brackets import

* Remove log message

* Don't change whitespace for no reason

* Fix prettier style issue

* Update search.dto.ts validators per @jrasm91's recommendation

* Update api types

* Combine null country and state into one guard clause

* chore: clean up

* chore: add e2e for null/empty city, state, country search

* refactor: server returns suggestion for null values

* chore: clean up

---------

Co-authored-by: Jason Rasmussen <jrasm91@gmail.com>
Co-authored-by: Alex Tran <alex.tran1502@gmail.com>
Co-authored-by: Jason Rasmussen <jason@rasm.me>
This commit is contained in:
Justin Forseth 2024-08-01 21:27:40 -06:00 • committed by GitHub
parent 3afb5b497f
commit d3a5490e71
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
21 changed files with 378 additions and 217 deletions
Download patch file Download diff file Expand all files Collapse all files

14
web/src/lib/components/shared-components/combobox.svelte
View file

@ -4,9 +4,16 @@
value: string;
};
export function toComboBoxOptions(items: string[]) {
return items.map<ComboBoxOption>((item) => ({ label: item, value: item }));
}
export const asComboboxOptions = (values: string[]) =>
values.map((value) => {
if (value === '') {
return { label: get(t)('unknown'), value: '' };
}
return { label: value, value };
});
export const asSelectedOption = (value?: string) => (value === undefined ? undefined : asComboboxOptions([value])[0]);
</script>
<script lang="ts">
@ -21,6 +28,7 @@
import { generateId } from '$lib/utils/generate-id';
import CircleIconButton from '$lib/components/elements/buttons/circle-icon-button.svelte';
import { t } from 'svelte-i18n';
import { get } from 'svelte/store';
export let label: string;
export let hideLabel = false;