From ce7f257d99451a7d2c6597844b192df71c560b5e Mon Sep 17 00:00:00 2001 From: bo0tzz Date: Sun, 2 Aug 2026 14:44:28 +0200 Subject: [PATCH] fix: don't swallow fetch errors Previously, it would just log "fetch failed" without any details about the cause. --- server/src/repositories/machine-learning.repository.ts | 4 +--- server/src/repositories/oauth.repository.ts | 5 ++--- 2 files changed, 3 insertions(+), 6 deletions(-) diff --git a/server/src/repositories/machine-learning.repository.ts b/server/src/repositories/machine-learning.repository.ts index c9825f31c1..26655bdd80 100644 --- a/server/src/repositories/machine-learning.repository.ts +++ b/server/src/repositories/machine-learning.repository.ts @@ -180,9 +180,7 @@ export class MachineLearningRepository { `Machine learning request to "${url}" failed with status ${response.status}: ${response.statusText}`, ); } catch (error: Error | unknown) { - this.logger.warn( - `Machine learning request to "${url}" failed: ${error instanceof Error ? error.message : error}`, - ); + this.logger.warn(`Machine learning request to "${url}" failed`, error); } this.setHealthy(url, false); diff --git a/server/src/repositories/oauth.repository.ts b/server/src/repositories/oauth.repository.ts index 1a09fff70d..fd0dc77f2b 100644 --- a/server/src/repositories/oauth.repository.ts +++ b/server/src/repositories/oauth.repository.ts @@ -122,8 +122,7 @@ export class OAuthRepository { ); } - this.logger.error(`OAuth login failed: ${error.message}`); - this.logger.error(error); + this.logger.error('OAuth login failed', error); throw new Error('OAuth login failed', { cause: error }); } @@ -222,7 +221,7 @@ export class OAuthRepository { }, ); } catch (error: any | AggregateError) { - this.logger.error(`Error in OAuth discovery: ${error}`, error?.stack, error?.errors); + this.logger.error('Error in OAuth discovery', error); throw new InternalServerErrorException(`Error in OAuth discovery: ${error}`, { cause: error }); } }