Set TypeScript to strict mode and fix issues related to server types (#261)

* Fix lint issues and some other TS issues

- set TypeScript in strict mode
- add npm commands to lint / check code
- fix all lint issues
- fix some TS issues
- rename User reponse DTO to make it consistent with the other ones
- override Express/User interface to use UserResponseDto interface
 This is for when the accessing the `user` from a Express Request,
 like in `asset-upload-config`

* Fix the rest of TS issues

- fix all the remaining TypeScript errors
- add missing `@types/mapbox__mapbox-sdk` package

* Move global.d.ts to server `src` folder

* Update AssetReponseDto duration type

This is now of type `string` that defaults to '0:00:00.00000' if not set
which is what the mobile app currently expects

* Set context when logging error in asset.service

Use `ServeFile` as the context for logging an error when
asset.resizePath is not set

* Fix wrong AppController merge conflict resolution

`redirectToWebpage` was removed in main as is no longer used.

server/apps/immich/src/api-v1/asset/asset.controller.ts

@@ -14,7 +14,6 @@ import {
   Headers,
   Delete,
   Logger,
-  Patch,
   HttpCode,
 } from '@nestjs/common';
 import { JwtAuthGuard } from '../../modules/immich-jwt/guards/jwt-auth.guard';
@@ -25,9 +24,7 @@ import { AuthUserDto, GetAuthUser } from '../../decorators/auth-user.decorator';
 import { CreateAssetDto } from './dto/create-asset.dto';
 import { ServeFileDto } from './dto/serve-file.dto';
 import { AssetEntity } from '@app/database/entities/asset.entity';
-import { GetAllAssetQueryDto } from './dto/get-all-asset-query.dto';
 import { Response as Res } from 'express';
-import { GetNewAssetQueryDto } from './dto/get-new-asset-query.dto';
 import { BackgroundTaskService } from '../../modules/background-task/background-task.service';
 import { DeleteAssetDto } from './dto/delete-asset.dto';
 import { SearchAssetDto } from './dto/search-asset.dto';
@@ -58,15 +55,18 @@ export class AssetController {
     ),
   )
   async uploadFile(
-    @GetAuthUser() authUser,
+    @GetAuthUser() authUser: AuthUserDto,
     @UploadedFiles() uploadFiles: { assetData: Express.Multer.File[]; thumbnailData?: Express.Multer.File[] },
     @Body(ValidationPipe) assetInfo: CreateAssetDto,
-  ) {
+  ): Promise<'ok' | undefined> {
     for (const file of uploadFiles.assetData) {
       try {
         const savedAsset = await this.assetService.createUserAsset(authUser, assetInfo, file.path, file.mimetype);
 
-        if (uploadFiles.thumbnailData != null && savedAsset) {
+        if (!savedAsset) {
+          return;
+        }
+        if (uploadFiles.thumbnailData != null) {
           const assetWithThumbnail = await this.assetService.updateThumbnailInfo(
             savedAsset,
             uploadFiles.thumbnailData[0].path,
@@ -107,11 +107,11 @@ export class AssetController {
 
   @Get('/file')
   async serveFile(
-    @Headers() headers,
+    @Headers() headers: Record<string, string>,
     @GetAuthUser() authUser: AuthUserDto,
     @Response({ passthrough: true }) res: Res,
     @Query(ValidationPipe) query: ServeFileDto,
-  ): Promise<StreamableFile> {
+  ): Promise<StreamableFile | undefined> {
     return this.assetService.serveFile(authUser, query, res, headers);
   }
 
@@ -151,7 +151,7 @@ export class AssetController {
   }
 
   @Get('/assetById/:assetId')
-  async getAssetById(@GetAuthUser() authUser: AuthUserDto, @Param('assetId') assetId) {
+  async getAssetById(@GetAuthUser() authUser: AuthUserDto, @Param('assetId') assetId: string) {
     return await this.assetService.getAssetById(authUser, assetId);
   }
 
@@ -161,6 +161,9 @@ export class AssetController {
 
     for (const id of assetIds.ids) {
       const assets = await this.assetService.getAssetById(authUser, id);
+      if (!assets) {
+        continue;
+      }
       deleteAssetList.push(assets);
     }