helpy4/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich synced 2025-11-14 17:36:12 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix(mobile): video player disposes early (#2275)

Browse source 
* fix(mobile): video player disposes early

* fixed show download button based on asset state

* style icon size

* disable screensleep on video player

* better position for video

* better scroll physics on iOS
This commit is contained in:
Alex 2023-04-18 11:23:56 -05:00 • committed by GitHub
parent 8a45c258c5
commit c8d3faec6d
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 53 additions and 35 deletions
Download patch file Download diff file Expand all files Collapse all files

6
mobile/lib/modules/asset_viewer/views/gallery_viewer.dart
View file

@ -301,7 +301,8 @@ class GalleryViewerPage extends HookConsumerWidget {
onFavorite: () {
toggleFavorite(assetList[indexOfAsset.value]);
},
onDownloadPressed: assetList[indexOfAsset.value].isLocal
onDownloadPressed: assetList[indexOfAsset.value].storage ==
AssetState.local
? null
: () {
ref.watch(imageViewerStateProvider.notifier).downloadAsset(
@ -391,7 +392,7 @@ class GalleryViewerPage extends HookConsumerWidget {
scrollPhysics: isZoomed.value
? const NeverScrollableScrollPhysics() // Don't allow paging while scrolled in
: (Platform.isIOS
? const BouncingScrollPhysics() // Use bouncing physics for iOS
? const ScrollPhysics() // Use bouncing physics for iOS
: const ClampingScrollPhysics() // Use heavy physics for Android
),
itemCount: assetList.length,
@ -516,6 +517,7 @@ class GalleryViewerPage extends HookConsumerWidget {
filterQuality: FilterQuality.high,
maxScale: 1.0,
minScale: 1.0,
basePosition: Alignment.bottomCenter,
child: SafeArea(
child: VideoViewerPage(
onPlaying: () => isPlayingVideo.value = true,