refactor(server): system config (#1353)

* refactor(server): system config

* fix: jest circular import

* chore: ignore migrations in coverage report

* chore: tests

* chore: tests

* chore: todo note

* chore: remove vite config backup

* chore: fix redis hostname

server/apps/microservices/src/microservices.module.ts

@@ -1,11 +1,9 @@
-import { immichAppConfig, immichBullAsyncConfig } from '@app/common/config';
+import { immichAppConfig } from '@app/common/config';
 import { AssetEntity, ExifEntity, SmartInfoEntity, UserEntity, APIKeyEntity, InfraModule } from '@app/infra';
 import { StorageModule } from '@app/storage';
-import { BullModule } from '@nestjs/bull';
 import { Module } from '@nestjs/common';
 import { ConfigModule } from '@nestjs/config';
 import { TypeOrmModule } from '@nestjs/typeorm';
-import { ImmichConfigModule } from 'libs/immich-config/src';
 import { CommunicationModule } from '../../immich/src/api-v1/communication/communication.module';
 import { MicroservicesService } from './microservices.service';
 import { AssetUploadedProcessor } from './processors/asset-uploaded.processor';
@@ -16,7 +14,6 @@ import { StorageMigrationProcessor } from './processors/storage-migration.proces
 import { ThumbnailGeneratorProcessor } from './processors/thumbnail.processor';
 import { UserDeletionProcessor } from './processors/user-deletion.processor';
 import { VideoTranscodeProcessor } from './processors/video-transcode.processor';
-import { immichSharedQueues } from '@app/job/constants/bull-queue-registration.constant';
 import { DomainModule } from '@app/domain';
 
 @Module({
@@ -25,11 +22,8 @@ import { DomainModule } from '@app/domain';
     DomainModule.register({
       imports: [InfraModule],
     }),
-    ImmichConfigModule,
     TypeOrmModule.forFeature([UserEntity, ExifEntity, AssetEntity, SmartInfoEntity, APIKeyEntity]),
     StorageModule,
-    BullModule.forRootAsync(immichBullAsyncConfig),
-    BullModule.registerQueue(...immichSharedQueues),
     CommunicationModule,
   ],
   controllers: [],
@@ -44,6 +38,5 @@ import { DomainModule } from '@app/domain';
     UserDeletionProcessor,
     StorageMigrationProcessor,
   ],
-  exports: [BullModule],
 })
 export class MicroservicesModule {}

server/apps/microservices/src/microservices.service.ts

@@ -1,4 +1,4 @@
-import { QueueName } from '@app/job';
+import { QueueName } from '@app/domain';
 import { InjectQueue } from '@nestjs/bull';
 import { Injectable, OnModuleInit } from '@nestjs/common';
 import { Queue } from 'bull';

server/apps/microservices/src/processors/asset-uploaded.processor.ts

@@ -6,7 +6,7 @@ import {
   IVideoTranscodeJob,
   QueueName,
   JobName,
-} from '@app/job';
+} from '@app/domain';
 import { InjectQueue, Process, Processor } from '@nestjs/bull';
 import { Job, Queue } from 'bull';
 

server/apps/microservices/src/processors/generate-checksum.processor.ts

@@ -1,5 +1,5 @@
 import { AssetEntity } from '@app/infra';
-import { QueueName } from '@app/job';
+import { QueueName } from '@app/domain';
 import { Process, Processor } from '@nestjs/bull';
 import { Logger } from '@nestjs/common';
 import { InjectRepository } from '@nestjs/typeorm';

server/apps/microservices/src/processors/machine-learning.processor.ts

@@ -1,7 +1,7 @@
 import { AssetEntity } from '@app/infra';
 import { SmartInfoEntity } from '@app/infra';
-import { QueueName, JobName } from '@app/job';
-import { IMachineLearningJob } from '@app/job/interfaces/machine-learning.interface';
+import { QueueName, JobName } from '@app/domain';
+import { IMachineLearningJob } from '@app/domain';
 import { Process, Processor } from '@nestjs/bull';
 import { Logger } from '@nestjs/common';
 import { InjectRepository } from '@nestjs/typeorm';

server/apps/microservices/src/processors/metadata-extraction.processor.ts

@@ -5,7 +5,7 @@ import {
   IVideoLengthExtractionProcessor,
   QueueName,
   JobName,
-} from '@app/job';
+} from '@app/domain';
 import { Process, Processor } from '@nestjs/bull';
 import { Logger } from '@nestjs/common';
 import { ConfigService } from '@nestjs/config';

server/apps/microservices/src/processors/storage-migration.processor.ts

@@ -1,7 +1,7 @@
 import { APP_UPLOAD_LOCATION } from '@app/common';
 import { AssetEntity } from '@app/infra';
-import { ImmichConfigService } from '@app/immich-config';
-import { QueueName, JobName } from '@app/job';
+import { SystemConfigService } from '@app/domain';
+import { QueueName, JobName } from '@app/domain';
 import { StorageService } from '@app/storage';
 import { Process, Processor } from '@nestjs/bull';
 import { Logger } from '@nestjs/common';
@@ -14,7 +14,7 @@ export class StorageMigrationProcessor {
 
   constructor(
     private storageService: StorageService,
-    private immichConfigService: ImmichConfigService,
+    private systemConfigService: SystemConfigService,
 
     @InjectRepository(AssetEntity)
     private assetRepository: Repository<AssetEntity>,
@@ -56,6 +56,6 @@ export class StorageMigrationProcessor {
    */
   @Process({ name: JobName.CONFIG_CHANGE, concurrency: 1 })
   async updateTemplate() {
-    await this.immichConfigService.refreshConfig();
+    await this.systemConfigService.refreshConfig();
   }
 }

server/apps/microservices/src/processors/thumbnail.processor.ts

@@ -1,6 +1,6 @@
 import { APP_UPLOAD_LOCATION } from '@app/common';
 import { AssetEntity, AssetType } from '@app/infra';
-import { WebpGeneratorProcessor, JpegGeneratorProcessor, QueueName, JobName } from '@app/job';
+import { WebpGeneratorProcessor, JpegGeneratorProcessor, QueueName, JobName } from '@app/domain';
 import { InjectQueue, Process, Processor } from '@nestjs/bull';
 import { Logger } from '@nestjs/common';
 import { InjectRepository } from '@nestjs/typeorm';
@@ -13,7 +13,7 @@ import sharp from 'sharp';
 import { Repository } from 'typeorm/repository/Repository';
 import { join } from 'path';
 import { CommunicationGateway } from 'apps/immich/src/api-v1/communication/communication.gateway';
-import { IMachineLearningJob } from '@app/job/interfaces/machine-learning.interface';
+import { IMachineLearningJob } from '@app/domain';
 
 @Processor(QueueName.THUMBNAIL_GENERATION)
 export class ThumbnailGeneratorProcessor {

server/apps/microservices/src/processors/user-deletion.processor.ts

@@ -1,7 +1,7 @@
 import { APP_UPLOAD_LOCATION, userUtils } from '@app/common';
 import { APIKeyEntity, AssetEntity, UserEntity } from '@app/infra';
-import { QueueName, JobName } from '@app/job';
-import { IUserDeletionJob } from '@app/job/interfaces/user-deletion.interface';
+import { QueueName, JobName } from '@app/domain';
+import { IUserDeletionJob } from '@app/domain';
 import { Process, Processor } from '@nestjs/bull';
 import { Logger } from '@nestjs/common';
 import { InjectRepository } from '@nestjs/typeorm';

server/apps/microservices/src/processors/video-transcode.processor.ts

@@ -1,14 +1,14 @@
 import { APP_UPLOAD_LOCATION } from '@app/common/constants';
 import { AssetEntity } from '@app/infra';
-import { QueueName, JobName } from '@app/job';
-import { IMp4ConversionProcessor } from '@app/job/interfaces/video-transcode.interface';
+import { QueueName, JobName } from '@app/domain';
+import { IMp4ConversionProcessor } from '@app/domain';
 import { Process, Processor } from '@nestjs/bull';
 import { Logger } from '@nestjs/common';
 import { InjectRepository } from '@nestjs/typeorm';
 import { Job } from 'bull';
 import ffmpeg from 'fluent-ffmpeg';
 import { existsSync, mkdirSync } from 'fs';
-import { ImmichConfigService } from 'libs/immich-config/src';
+import { SystemConfigService } from '@app/domain';
 import { Repository } from 'typeorm';
 
 @Processor(QueueName.VIDEO_CONVERSION)
@@ -16,7 +16,7 @@ export class VideoTranscodeProcessor {
   constructor(
     @InjectRepository(AssetEntity)
     private assetRepository: Repository<AssetEntity>,
-    private immichConfigService: ImmichConfigService,
+    private systemConfigService: SystemConfigService,
   ) {}
 
   @Process({ name: JobName.MP4_CONVERSION, concurrency: 2 })
@@ -41,7 +41,7 @@ export class VideoTranscodeProcessor {
   }
 
   async runFFMPEGPipeLine(asset: AssetEntity, savedEncodedPath: string): Promise<void> {
-    const config = await this.immichConfigService.getConfig();
+    const config = await this.systemConfigService.getConfig();
 
     return new Promise((resolve, reject) => {
       ffmpeg(asset.originalPath)