refactor(server)!: add/remove album assets (#3109)

* refactor: add/remove album assets

* chore: open api

* feat: remove owned assets from album

* refactor: move to bulk id req/res dto

* chore: open api

* chore: merge main

* dev: mobile work

* fix: adding asset from web not sync with mobile

* remove print statement

---------

Co-authored-by: Alex Tran <Alex.Tran@conductix.com>

web/src/lib/components/album-page/album-viewer.svelte

@@ -92,6 +92,7 @@
 
   let multiSelectAsset: Set<AssetResponseDto> = new Set();
   $: isMultiSelectionMode = multiSelectAsset.size > 0;
+  $: isMultiSelectionUserOwned = Array.from(multiSelectAsset).every((asset) => asset.ownerId === currentUser?.id);
 
   afterNavigate(({ from }) => {
     backUrl = from?.url.pathname ?? '/albums';
@@ -182,24 +183,24 @@
   const createAlbumHandler = async (event: CustomEvent) => {
     const { assets }: { assets: AssetResponseDto[] } = event.detail;
     try {
-      const { data } = await api.albumApi.addAssetsToAlbum({
+      const { data: results } = await api.albumApi.addAssetsToAlbum({
         id: album.id,
-        addAssetsDto: {
-          assetIds: assets.map((a) => a.id),
-        },
+        bulkIdsDto: { ids: assets.map((a) => a.id) },
         key: sharedLink?.key,
       });
 
-      if (data.album) {
-        album = data.album;
-      }
+      const count = results.filter(({ success }) => success).length;
+      notificationController.show({
+        type: NotificationType.Info,
+        message: `Added ${count} asset${count === 1 ? '' : 's'}`,
+      });
+
+      const { data } = await api.albumApi.getAlbumInfo({ id: album.id });
+      album = data;
+
       isShowAssetSelection = false;
     } catch (e) {
-      console.error('Error [createAlbumHandler] ', e);
-      notificationController.show({
-        type: NotificationType.Error,
-        message: 'Error creating album, check console for more details',
-      });
+      handleError(e, 'Error creating album');
     }
   };
 
@@ -307,7 +308,7 @@
       {#if sharedLink?.allowDownload || !isPublicShared}
         <DownloadAction filename="{album.albumName}.zip" sharedLinkKey={sharedLink?.key} />
       {/if}
-      {#if isOwned}
+      {#if isOwned || isMultiSelectionUserOwned}
         <RemoveFromAlbum bind:album />
       {/if}
     </AssetSelectControlBar>

web/src/lib/components/asset-viewer/asset-viewer.svelte

@@ -189,11 +189,8 @@
     isShowAlbumPicker = false;
     const album = event.detail.album;
 
-    addAssetsToAlbum(album.id, [asset.id]).then((dto) => {
-      if (dto.successfullyAdded === 1 && dto.album) {
-        appearsInAlbums = [...appearsInAlbums, dto.album];
-      }
-    });
+    await addAssetsToAlbum(album.id, [asset.id]);
+    await getAllAlbums();
   };
 
   const disableKeyDownEvent = () => {

web/src/lib/components/photos-page/actions/add-to-album.svelte

@@ -44,10 +44,9 @@
   const handleAddToAlbum = async (event: CustomEvent<{ album: AlbumResponseDto }>) => {
     showAlbumPicker = false;
     const album = event.detail.album;
-
     const assetIds = Array.from(getAssets()).map((asset) => asset.id);
-
-    addAssetsToAlbum(album.id, assetIds).then(clearSelect);
+    await addAssetsToAlbum(album.id, assetIds);
+    clearSelect();
   };
 </script>
 

web/src/lib/components/photos-page/actions/remove-from-album.svelte

@@ -17,14 +17,20 @@
 
   const removeFromAlbum = async () => {
     try {
-      const { data } = await api.albumApi.removeAssetFromAlbum({
+      const { data: results } = await api.albumApi.removeAssetFromAlbum({
         id: album.id,
-        removeAssetsDto: {
-          assetIds: Array.from(getAssets()).map((a) => a.id),
-        },
+        bulkIdsDto: { ids: Array.from(getAssets()).map((a) => a.id) },
       });
 
+      const { data } = await api.albumApi.getAlbumInfo({ id: album.id });
       album = data;
+
+      const count = results.filter(({ success }) => success).length;
+      notificationController.show({
+        type: NotificationType.Info,
+        message: `Removed ${count} asset${count === 1 ? '' : 's'}`,
+      });
+
       clearSelect();
     } catch (e) {
       console.error('Error [album-viewer] [removeAssetFromAlbum]', e);