helpy4/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich synced 2025-11-07 17:27:20 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix Notification components possible memory leaks (#650)

Browse source 
Dispose subscriptions and timeouts when
the components are removed from the DOM
This commit is contained in:
Jaime Baez 2022-09-09 14:40:35 +02:00 • committed by GitHub
parent cc79ff1ca3
commit b6d025da09
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 96 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

12
web/src/lib/components/shared-components/notification/notification-card.svelte
View file

@ -48,10 +48,14 @@
}
};
let removeNotificationTimeout: NodeJS.Timeout | undefined = undefined;
onMount(() => {
setTimeout(() => {
removeNotificationTimeout = setTimeout(() => {
notificationController.removeNotificationById(notificationInfo.id);
}, notificationInfo.timeout);
return () => clearTimeout(removeNotificationTimeout);
});
</script>
@ -63,8 +67,10 @@
>
<div class="flex gap-2 place-items-center">
<svelte:component this={icon} color={primaryColor()} size="20" />
<h2 style:color={primaryColor()} class="font-medium">{notificationInfo.type.toString()}</h2>
<h2 style:color={primaryColor()} class="font-medium" data-testid="title">
{notificationInfo.type.toString()}
</h2>
</div>
<p class="text-sm pl-[28px] pr-[16px]">{notificationInfo.message}</p>
<p class="text-sm pl-[28px] pr-[16px]" data-testid="message">{notificationInfo.message}</p>
</div>