refactor: migrate some e2e to medium (#17640)

server/test/medium/specs/controllers/auth.controller.spec.ts

@@ -0,0 +1,60 @@
+import { AuthController } from 'src/controllers/auth.controller';
+import { AuthService } from 'src/services/auth.service';
+import request from 'supertest';
+import { errorDto } from 'test/medium/responses';
+import { createControllerTestApp, TestControllerApp } from 'test/medium/utils';
+
+describe(AuthController.name, () => {
+  let app: TestControllerApp;
+
+  beforeAll(async () => {
+    app = await createControllerTestApp();
+  });
+
+  describe('POST /auth/admin-sign-up', () => {
+    const name = 'admin';
+    const email = 'admin@immich.cloud';
+    const password = 'password';
+
+    const invalid = [
+      {
+        should: 'require an email address',
+        data: { name, password },
+      },
+      {
+        should: 'require a password',
+        data: { name, email },
+      },
+      {
+        should: 'require a name',
+        data: { email, password },
+      },
+      {
+        should: 'require a valid email',
+        data: { name, email: 'immich', password },
+      },
+    ];
+
+    for (const { should, data } of invalid) {
+      it(`should ${should}`, async () => {
+        const { status, body } = await request(app.getHttpServer()).post('/auth/admin-sign-up').send(data);
+        expect(status).toEqual(400);
+        expect(body).toEqual(errorDto.badRequest());
+      });
+    }
+
+    it('should transform email to lower case', async () => {
+      const { status } = await request(app.getHttpServer())
+        .post('/auth/admin-sign-up')
+        .send({ name: 'admin', password: 'password', email: 'aDmIn@IMMICH.cloud' });
+      expect(status).toEqual(201);
+      expect(app.getMockedService(AuthService).adminSignUp).toHaveBeenCalledWith(
+        expect.objectContaining({ email: 'admin@immich.cloud' }),
+      );
+    });
+  });
+
+  afterAll(async () => {
+    await app.close();
+  });
+});

server/test/medium/specs/controllers/user.controller.spec.ts

@@ -0,0 +1,100 @@
+import { UserController } from 'src/controllers/user.controller';
+import { AuthService } from 'src/services/auth.service';
+import { UserService } from 'src/services/user.service';
+import request from 'supertest';
+import { errorDto } from 'test/medium/responses';
+import { createControllerTestApp, TestControllerApp } from 'test/medium/utils';
+import { factory } from 'test/small.factory';
+
+describe(UserController.name, () => {
+  let realApp: TestControllerApp;
+  let mockApp: TestControllerApp;
+
+  beforeAll(async () => {
+    realApp = await createControllerTestApp({ authType: 'real' });
+    mockApp = await createControllerTestApp({ authType: 'mock' });
+  });
+
+  describe('GET /users', () => {
+    it('should require authentication', async () => {
+      const { status, body } = await request(realApp.getHttpServer()).get('/users');
+      expect(status).toBe(401);
+      expect(body).toEqual(errorDto.unauthorized);
+    });
+
+    it('should call the service with an auth dto', async () => {
+      const user = factory.user();
+      const authService = mockApp.getMockedService(AuthService);
+      const auth = factory.auth({ user });
+      authService.authenticate.mockResolvedValue(auth);
+
+      const userService = mockApp.getMockedService(UserService);
+      const { status } = await request(mockApp.getHttpServer()).get('/users').set('Authorization', `Bearer token`);
+
+      expect(status).toBe(200);
+      expect(userService.search).toHaveBeenCalledWith(auth);
+    });
+  });
+
+  describe('GET /users/me', () => {
+    it('should require authentication', async () => {
+      const { status, body } = await request(realApp.getHttpServer()).get(`/users/me`);
+      expect(status).toBe(401);
+      expect(body).toEqual(errorDto.unauthorized);
+    });
+  });
+
+  describe('PUT /users/me', () => {
+    it('should require authentication', async () => {
+      const { status, body } = await request(realApp.getHttpServer()).put(`/users/me`);
+      expect(status).toBe(401);
+      expect(body).toEqual(errorDto.unauthorized);
+    });
+
+    for (const key of ['email', 'name']) {
+      it(`should not allow null ${key}`, async () => {
+        const dto = { [key]: null };
+        const { status, body } = await request(mockApp.getHttpServer())
+          .put(`/users/me`)
+          .set('Authorization', `Bearer token`)
+          .send(dto);
+        expect(status).toBe(400);
+        expect(body).toEqual(errorDto.badRequest());
+      });
+    }
+  });
+
+  describe('GET /users/:id', () => {
+    it('should require authentication', async () => {
+      const { status } = await request(realApp.getHttpServer()).get(`/users/${factory.uuid()}`);
+      expect(status).toEqual(401);
+    });
+  });
+
+  describe('GET /server/license', () => {
+    it('should require authentication', async () => {
+      const { status, body } = await request(realApp.getHttpServer()).get('/users/me/license');
+      expect(status).toBe(401);
+      expect(body).toEqual(errorDto.unauthorized);
+    });
+  });
+
+  describe('PUT /users/me/license', () => {
+    it('should require authentication', async () => {
+      const { status } = await request(realApp.getHttpServer()).put(`/users/me/license`);
+      expect(status).toEqual(401);
+    });
+  });
+
+  describe('DELETE /users/me/license', () => {
+    it('should require authentication', async () => {
+      const { status } = await request(realApp.getHttpServer()).put(`/users/me/license`);
+      expect(status).toEqual(401);
+    });
+  });
+
+  afterAll(async () => {
+    await realApp.close();
+    await mockApp.close();
+  });
+});

server/test/medium/specs/services/user.service.spec.ts

@@ -60,6 +60,25 @@ describe(UserService.name, () => {
     });
   });
 
+  describe('search', () => {
+    it('should get users', async () => {
+      const { sut, repos } = createSut();
+      const user1 = mediumFactory.userInsert();
+      const user2 = mediumFactory.userInsert();
+
+      await Promise.all([repos.user.create(user1), repos.user.create(user2)]);
+
+      const auth = factory.auth({ user: user1 });
+
+      await expect(sut.search(auth)).resolves.toEqual(
+        expect.arrayContaining([
+          expect.objectContaining({ email: user1.email }),
+          expect.objectContaining({ email: user2.email }),
+        ]),
+      );
+    });
+  });
+
   describe('get', () => {
     it('should get a user', async () => {
       const { sut, repos } = createSut();