helpy4/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich synced 2025-10-17 18:19:27 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix(ml): race condition when loading models (#3207)

Browse source 
* sync model loading, disabled model ttl by default

* disable revalidation if model unloading disabled

* moved lock
This commit is contained in:
Mert 2023-07-11 13:01:21 -04:00 • committed by GitHub
parent 9ad024c189
commit 848ba685eb
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 6 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

12
machine-learning/app/models/cache.py
View file

@ -1,4 +1,3 @@
import asyncio
from typing import Any
from aiocache.backends.memory import SimpleMemoryCache
@ -48,13 +47,10 @@ class ModelCache:
"""
key = self.cache.build_key(model_name, model_type.value)
model = await self.cache.get(key)
if model is None:
async with OptimisticLock(self.cache, key) as lock:
model = await asyncio.get_running_loop().run_in_executor(
None,
lambda: InferenceModel.from_model_type(model_type, model_name, **model_kwargs),
)
async with OptimisticLock(self.cache, key) as lock:
model = await self.cache.get(key)
if model is None:
model = InferenceModel.from_model_type(model_type, model_name, **model_kwargs)
await lock.cas(model, ttl=self.ttl)
return model