helpy4/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich synced 2025-11-07 17:27:20 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

chore: hero animations (#19860)

Browse source 
* remove herocontrollerscope

* handle heroOffset in new timeline

---------

Co-authored-by: shenlong-tanwen <139912620+shalong-tanwen@users.noreply.github.com>
Co-authored-by: Alex <alex.tran1502@gmail.com>
This commit is contained in:
shenlong 2025-07-11 01:55:18 +05:30 • committed by GitHub
parent 70b73145f1
commit 7d8f56b483
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
5 changed files with 20 additions and 20 deletions
Download patch file Download diff file Expand all files Collapse all files

8
mobile/lib/pages/common/tab_shell.page.dart
View file

@ -127,10 +127,6 @@ class TabShellPage extends ConsumerWidget {
),
builder: (context, child) {
final tabsRouter = AutoTabsRouter.of(context);
final heroedChild = HeroControllerScope(
controller: HeroController(),
child: child,
);
return PopScope(
canPop: tabsRouter.activeIndex == 0,
onPopInvokedWithResult: (didPop, _) =>
@ -142,10 +138,10 @@ class TabShellPage extends ConsumerWidget {
children: [
navigationRail(tabsRouter),
const VerticalDivider(),
Expanded(child: heroedChild),
Expanded(child: child),
],
)
: heroedChild,
: child,
bottomNavigationBar: _BottomNavigationBar(
tabsRouter: tabsRouter,
destinations: navigationDestinations,