fix: The 'Copy Link' function will prioritize copying any available custom URL, mirroring the behavior found on the web version

2025-11-07 17:27:20 +00:00 · 2025-09-09 21:42:32 +02:00 · 2025-09-09 21:42:32 +02:00 · 7af9d6d7b7
commit 7af9d6d7b7
parent 27bc8eba7b
7 changed files with 502 additions and 3 deletions
--- a/mobile/test/modules/shared_link/shared_link_item_test.dart
+++ b/mobile/test/modules/shared_link/shared_link_item_test.dart
@ -0,0 +1,130 @@
+@Tags(['widget'])
+library;
+
+import 'package:flutter/material.dart';
+import 'package:flutter_test/flutter_test.dart';
+import 'package:hooks_riverpod/hooks_riverpod.dart';
+import 'package:isar/isar.dart';
+import 'package:mocktail/mocktail.dart';
+
+import 'package:immich_mobile/domain/models/store.model.dart';
+import 'package:immich_mobile/domain/services/store.service.dart';
+import 'package:immich_mobile/entities/store.entity.dart';
+import 'package:immich_mobile/infrastructure/repositories/store.repository.dart';
+import 'package:immich_mobile/providers/server_info.provider.dart';
+import 'package:immich_mobile/providers/shared_link.provider.dart';
+import 'package:immich_mobile/widgets/shared_link/shared_link_item.dart';
+
+import '../../fixtures/user.stub.dart';
+import '../../test_utils.dart';
+import '../../widget_tester_extensions.dart';
+import 'shared_link_test_utils.dart';
+
+void main() {
+  late MockServerInfoNotifier mockServerInfoNotifier;
+  late MockSharedLinksNotifier mockSharedLinksNotifier;
+  late List<Override> overrides;
+  late ClipboardCapturer clipboardCapturer;
+  late Isar db;
+
+  final sharedLinkWithSlug = createSharedLinkWithSlug();
+  final sharedLinkWithoutSlug = createSharedLinkWithoutSlug();
+
+  setUpAll(() async {
+    TestUtils.init();
+    db = await TestUtils.initIsar();
+  });
+
+  setUp(() async {
+    await StoreService.init(storeRepository: IsarStoreRepository(db));
+
+    await Store.put(StoreKey.currentUser, UserStub.admin);
+    await Store.put(StoreKey.serverEndpoint, 'http://example.com');
+    await Store.put(StoreKey.accessToken, 'test-token');
+    await Store.put(StoreKey.serverUrl, 'http://example.com');
+
+    mockServerInfoNotifier = MockServerInfoNotifier();
+    mockSharedLinksNotifier = MockSharedLinksNotifier();
+    clipboardCapturer = ClipboardCapturer();
+
+    setupDefaultServerInfo(mockServerInfoNotifier);
+    mockSharedLinksNotifier.state = const AsyncValue.data([]);
+
+    overrides = [
+      serverInfoProvider.overrideWith((ref) => mockServerInfoNotifier),
+      sharedLinksStateProvider.overrideWith((ref) => mockSharedLinksNotifier),
+    ];
+
+    setupClipboardMock(clipboardCapturer);
+
+    when(() => mockSharedLinksNotifier.deleteLink(any())).thenAnswer((_) async {});
+  });
+
+  tearDown(() {
+    reset(mockSharedLinksNotifier);
+    cleanupClipboardMock();
+    clipboardCapturer.clear();
+    StoreService.I.dispose();
+  });
+
+  group('SharedLinkItem Tests', () {
+    testWidgets('copies URL with slug to clipboard', (tester) async {
+      await tester.pumpConsumerWidget(Scaffold(body: SharedLinkItem(sharedLinkWithSlug)), overrides: overrides);
+
+      final copyButton = find.byIcon(Icons.copy_outlined);
+      await tester.tap(copyButton);
+      await tester.pumpAndSettle();
+
+      expect(clipboardCapturer.text, 'https://example.com/s/test-slug');
+    });
+
+    testWidgets('copies URL without slug to clipboard', (tester) async {
+      await tester.pumpConsumerWidget(Scaffold(body: SharedLinkItem(sharedLinkWithoutSlug)), overrides: overrides);
+
+      final copyButton = find.byIcon(Icons.copy_outlined);
+      await tester.tap(copyButton);
+      await tester.pumpAndSettle();
+
+      expect(clipboardCapturer.text, 'https://example.com/share/test-key-2');
+    });
+
+    testWidgets('handles empty external domain by using server URL', (tester) async {
+      setupEmptyExternalDomain(mockServerInfoNotifier);
+      await Store.put(StoreKey.serverEndpoint, 'http://example.com');
+
+      await tester.pumpConsumerWidget(Scaffold(body: SharedLinkItem(sharedLinkWithSlug)), overrides: overrides);
+
+      final copyButton = find.byIcon(Icons.copy_outlined);
+      await tester.tap(copyButton);
+      await tester.pumpAndSettle();
+
+      expect(clipboardCapturer.text, 'http://example.com/s/test-slug');
+    });
+
+    testWidgets('shows snackbar on successful copy', (tester) async {
+      await tester.pumpConsumerWidget(Scaffold(body: SharedLinkItem(sharedLinkWithSlug)), overrides: overrides);
+
+      final copyButton = find.byIcon(Icons.copy_outlined);
+      await tester.tap(copyButton);
+      await tester.pumpAndSettle();
+
+      expect(find.textContaining('copied'), findsOneWidget);
+    });
+
+    testWidgets('works with different shared links', (tester) async {
+      await tester.pumpConsumerWidget(Scaffold(body: SharedLinkItem(sharedLinkWithSlug)), overrides: overrides);
+
+      final copyButton = find.byIcon(Icons.copy_outlined);
+      await tester.tap(copyButton);
+      await tester.pumpAndSettle();
+
+      expect(clipboardCapturer.text, 'https://example.com/s/test-slug');
+
+      await tester.pumpConsumerWidget(Scaffold(body: SharedLinkItem(sharedLinkWithoutSlug)), overrides: overrides);
+      await tester.tap(copyButton);
+      await tester.pumpAndSettle();
+
+      expect(clipboardCapturer.text, 'https://example.com/share/test-key-2');
+    });
+  });
+}