feat(mobile): use app without storage permission (#5014)

* feat(mobile): use app without storage permission

* address review feedback

mobile/lib/modules/backup/providers/backup.provider.dart

@@ -89,7 +89,6 @@ class BackupNotifier extends StateNotifier<BackUpState> {
 
     state = state
         .copyWith(selectedBackupAlbums: {...state.selectedBackupAlbums, album});
-    _updateBackupAssetCount();
   }
 
   void addExcludedAlbumForBackup(AvailableAlbum album) {
@@ -98,7 +97,6 @@ class BackupNotifier extends StateNotifier<BackUpState> {
     }
     state = state
         .copyWith(excludedBackupAlbums: {...state.excludedBackupAlbums, album});
-    _updateBackupAssetCount();
   }
 
   void removeAlbumForBackup(AvailableAlbum album) {
@@ -107,7 +105,6 @@ class BackupNotifier extends StateNotifier<BackUpState> {
     currentSelectedAlbums.removeWhere((a) => a == album);
 
     state = state.copyWith(selectedBackupAlbums: currentSelectedAlbums);
-    _updateBackupAssetCount();
   }
 
   void removeExcludedAlbumForBackup(AvailableAlbum album) {
@@ -116,7 +113,20 @@ class BackupNotifier extends StateNotifier<BackUpState> {
     currentExcludedAlbums.removeWhere((a) => a == album);
 
     state = state.copyWith(excludedBackupAlbums: currentExcludedAlbums);
-    _updateBackupAssetCount();
+  }
+
+  Future<void> backupAlbumSelectionDone() {
+    if (state.selectedBackupAlbums.isEmpty) {
+      // disable any backup
+      cancelBackup();
+      setAutoBackup(false);
+      configureBackgroundBackup(
+        enabled: false,
+        onError: (msg) {},
+        onBatteryInfo: () {},
+      );
+    }
+    return _updateBackupAssetCount();
   }
 
   void setAutoBackup(bool enabled) {
@@ -249,30 +259,6 @@ class BackupNotifier extends StateNotifier<BackUpState> {
     final List<BackupAlbum> selectedBackupAlbums =
         await _backupService.selectedAlbumsQuery().findAll();
 
-    // First time backup - set isAll album is the default one for backup.
-    if (selectedBackupAlbums.isEmpty) {
-      log.info("First time backup; setup 'Recent(s)' album as default");
-
-      // Get album that contains all assets
-      final list = await PhotoManager.getAssetPathList(
-        hasAll: true,
-        onlyAll: true,
-        type: RequestType.common,
-      );
-
-      if (list.isEmpty) {
-        return;
-      }
-      AssetPathEntity albumHasAllAssets = list.first;
-
-      final ba = BackupAlbum(
-        albumHasAllAssets.id,
-        DateTime.fromMillisecondsSinceEpoch(0),
-        BackupSelection.select,
-      );
-      await _db.writeTxn(() => _db.backupAlbums.put(ba));
-    }
-
     // Generate AssetPathEntity from id to add to local state
     final Set<AvailableAlbum> selectedAlbums = {};
     for (final BackupAlbum ba in selectedBackupAlbums) {
@@ -362,7 +348,6 @@ class BackupNotifier extends StateNotifier<BackUpState> {
         allUniqueAssets: {},
         selectedAlbumsBackupAssetsIds: selectedAlbumsBackupAssets,
       );
-      return;
     } else {
       state = state.copyWith(
         allAssetsInDatabase: allAssetsInDatabase,
@@ -373,8 +358,6 @@ class BackupNotifier extends StateNotifier<BackUpState> {
 
     // Save to persistent storage
     await _updatePersistentAlbumsSelection();
-
-    return;
   }
 
   /// Get all necessary information for calculating the available albums,

mobile/lib/modules/backup/ui/album_info_card.dart

@@ -82,19 +82,9 @@ class AlbumInfoCard extends HookConsumerWidget {
         HapticFeedback.selectionClick();
 
         if (isSelected) {
-          if (ref.watch(backupProvider).selectedBackupAlbums.length == 1) {
-            ImmichToast.show(
-              context: context,
-              msg: "backup_err_only_album".tr(),
-              toastType: ToastType.error,
-              gravity: ToastGravity.BOTTOM,
-            );
-            return;
-          }
-
-          ref.watch(backupProvider.notifier).removeAlbumForBackup(albumInfo);
+          ref.read(backupProvider.notifier).removeAlbumForBackup(albumInfo);
         } else {
-          ref.watch(backupProvider.notifier).addAlbumForBackup(albumInfo);
+          ref.read(backupProvider.notifier).addAlbumForBackup(albumInfo);
         }
       },
       onDoubleTap: () {
@@ -103,23 +93,10 @@ class AlbumInfoCard extends HookConsumerWidget {
         if (isExcluded) {
           // Remove from exclude album list
           ref
-              .watch(backupProvider.notifier)
+              .read(backupProvider.notifier)
               .removeExcludedAlbumForBackup(albumInfo);
         } else {
           // Add to exclude album list
-          if (ref.watch(backupProvider).selectedBackupAlbums.length == 1 &&
-              ref
-                  .watch(backupProvider)
-                  .selectedBackupAlbums
-                  .contains(albumInfo)) {
-            ImmichToast.show(
-              context: context,
-              msg: "backup_err_only_album".tr(),
-              toastType: ToastType.error,
-              gravity: ToastGravity.BOTTOM,
-            );
-            return;
-          }
 
           if (albumInfo.id == 'isAll' || albumInfo.name == 'Recents') {
             ImmichToast.show(
@@ -132,7 +109,7 @@ class AlbumInfoCard extends HookConsumerWidget {
           }
 
           ref
-              .watch(backupProvider.notifier)
+              .read(backupProvider.notifier)
               .addExcludedAlbumForBackup(albumInfo);
         }
       },

mobile/lib/modules/backup/ui/album_info_list_tile.dart

@@ -1,4 +1,3 @@
-import 'package:easy_localization/easy_localization.dart';
 import 'package:flutter/material.dart';
 import 'package:flutter/services.dart';
 import 'package:flutter_hooks/flutter_hooks.dart';
@@ -74,23 +73,10 @@ class AlbumInfoListTile extends HookConsumerWidget {
         if (isExcluded) {
           // Remove from exclude album list
           ref
-              .watch(backupProvider.notifier)
+              .read(backupProvider.notifier)
               .removeExcludedAlbumForBackup(albumInfo);
         } else {
           // Add to exclude album list
-          if (ref.watch(backupProvider).selectedBackupAlbums.length == 1 &&
-              ref
-                  .watch(backupProvider)
-                  .selectedBackupAlbums
-                  .contains(albumInfo)) {
-            ImmichToast.show(
-              context: context,
-              msg: "backup_err_only_album".tr(),
-              toastType: ToastType.error,
-              gravity: ToastGravity.BOTTOM,
-            );
-            return;
-          }
 
           if (albumInfo.id == 'isAll' || albumInfo.name == 'Recents') {
             ImmichToast.show(
@@ -103,7 +89,7 @@ class AlbumInfoListTile extends HookConsumerWidget {
           }
 
           ref
-              .watch(backupProvider.notifier)
+              .read(backupProvider.notifier)
               .addExcludedAlbumForBackup(albumInfo);
         }
       },
@@ -113,19 +99,9 @@ class AlbumInfoListTile extends HookConsumerWidget {
         onTap: () {
           HapticFeedback.selectionClick();
           if (isSelected) {
-            if (ref.watch(backupProvider).selectedBackupAlbums.length == 1) {
-              ImmichToast.show(
-                context: context,
-                msg: "backup_err_only_album".tr(),
-                toastType: ToastType.error,
-                gravity: ToastGravity.BOTTOM,
-              );
-              return;
-            }
-
-            ref.watch(backupProvider.notifier).removeAlbumForBackup(albumInfo);
+            ref.read(backupProvider.notifier).removeAlbumForBackup(albumInfo);
           } else {
-            ref.watch(backupProvider.notifier).addAlbumForBackup(albumInfo);
+            ref.read(backupProvider.notifier).addAlbumForBackup(albumInfo);
           }
         },
         leading: ClipRRect(

mobile/lib/modules/backup/views/backup_album_selection_page.dart

@@ -1,7 +1,6 @@
 import 'package:easy_localization/easy_localization.dart';
 import 'package:flutter/material.dart';
 import 'package:flutter_hooks/flutter_hooks.dart';
-import 'package:fluttertoast/fluttertoast.dart';
 import 'package:hooks_riverpod/hooks_riverpod.dart';
 import 'package:immich_mobile/constants/immich_colors.dart';
 import 'package:immich_mobile/extensions/build_context_extensions.dart';
@@ -9,7 +8,6 @@ import 'package:immich_mobile/modules/backup/providers/backup.provider.dart';
 import 'package:immich_mobile/modules/backup/ui/album_info_card.dart';
 import 'package:immich_mobile/modules/backup/ui/album_info_list_tile.dart';
 import 'package:immich_mobile/shared/ui/immich_loading_indicator.dart';
-import 'package:immich_mobile/shared/ui/immich_toast.dart';
 
 class BackupAlbumSelectionPage extends HookConsumerWidget {
   const BackupAlbumSelectionPage({Key? key}) : super(key: key);
@@ -91,19 +89,8 @@ class BackupAlbumSelectionPage extends HookConsumerWidget {
 
     buildSelectedAlbumNameChip() {
       return selectedBackupAlbums.map((album) {
-        void removeSelection() {
-          if (ref.watch(backupProvider).selectedBackupAlbums.length == 1) {
-            ImmichToast.show(
-              context: context,
-              msg: "backup_err_only_album".tr(),
-              toastType: ToastType.error,
-              gravity: ToastGravity.BOTTOM,
-            );
-            return;
-          }
-
-          ref.watch(backupProvider.notifier).removeAlbumForBackup(album);
-        }
+        void removeSelection() =>
+            ref.read(backupProvider.notifier).removeAlbumForBackup(album);
 
         return Padding(
           padding: const EdgeInsets.only(right: 8.0),
@@ -252,47 +239,6 @@ class BackupAlbumSelectionPage extends HookConsumerWidget {
                   ),
                 ),
 
-                Padding(
-                  padding:
-                      const EdgeInsets.symmetric(horizontal: 16.0, vertical: 8),
-                  child: Card(
-                    margin: const EdgeInsets.all(0),
-                    shape: RoundedRectangleBorder(
-                      borderRadius: BorderRadius.circular(10),
-                      side: BorderSide(
-                        color: isDarkTheme
-                            ? const Color.fromARGB(255, 0, 0, 0)
-                            : const Color.fromARGB(255, 235, 235, 235),
-                        width: 1,
-                      ),
-                    ),
-                    elevation: 0,
-                    borderOnForeground: false,
-                    child: Column(
-                      children: [
-                        ListTile(
-                          visualDensity: VisualDensity.compact,
-                          title: const Text(
-                            "backup_album_selection_page_total_assets",
-                            style: TextStyle(
-                              fontWeight: FontWeight.bold,
-                              fontSize: 14,
-                            ),
-                          ).tr(),
-                          trailing: Text(
-                            ref
-                                .watch(backupProvider)
-                                .allUniqueAssets
-                                .length
-                                .toString(),
-                            style: const TextStyle(fontWeight: FontWeight.bold),
-                          ),
-                        ),
-                      ],
-                    ),
-                  ),
-                ),
-
                 ListTile(
                   title: Text(
                     "backup_album_selection_page_albums_device".tr(

mobile/lib/modules/backup/views/backup_controller_page.dart

@@ -6,6 +6,7 @@ import 'package:flutter/material.dart';
 import 'package:flutter_hooks/flutter_hooks.dart';
 import 'package:hooks_riverpod/hooks_riverpod.dart';
 import 'package:immich_mobile/extensions/build_context_extensions.dart';
+import 'package:immich_mobile/modules/album/providers/album.provider.dart';
 import 'package:immich_mobile/modules/backup/background_service/background.service.dart';
 import 'package:immich_mobile/modules/backup/providers/error_backup_list.provider.dart';
 import 'package:immich_mobile/modules/backup/providers/ios_background_settings.provider.dart';
@@ -38,6 +39,7 @@ class BackupControllerPage extends HookConsumerWidget {
     final settingsService = ref.watch(appSettingsServiceProvider);
     final showBackupFix = Platform.isAndroid &&
         settingsService.getSetting(AppSettingsEnum.advancedTroubleshooting);
+    final hasAnyAlbum = backupState.selectedBackupAlbums.isNotEmpty;
 
     final appRefreshDisabled =
         Platform.isIOS && settings?.appRefreshEnabled != true;
@@ -590,8 +592,14 @@ class BackupControllerPage extends HookConsumerWidget {
             ),
           ),
           trailing: ElevatedButton(
-            onPressed: () {
-              context.autoPush(const BackupAlbumSelectionRoute());
+            onPressed: () async {
+              await context.autoPush(const BackupAlbumSelectionRoute());
+              // waited until returning from selection
+              await ref
+                  .read(backupProvider.notifier)
+                  .backupAlbumSelectionDone();
+              // waited until backup albums are stored in DB
+              ref.read(albumProvider.notifier).getDeviceAlbums();
             },
             child: const Text(
               "backup_controller_page_select",
@@ -689,55 +697,50 @@ class BackupControllerPage extends HookConsumerWidget {
         padding: const EdgeInsets.only(left: 16.0, right: 16, bottom: 32),
         child: ListView(
           // crossAxisAlignment: CrossAxisAlignment.start,
-          children: [
-            Padding(
-              padding: const EdgeInsets.all(8.0),
-              child: const Text(
-                "backup_controller_page_info",
-                style: TextStyle(fontWeight: FontWeight.bold, fontSize: 16),
-              ).tr(),
-            ),
-            buildFolderSelectionTile(),
-            BackupInfoCard(
-              title: "backup_controller_page_total".tr(),
-              subtitle: "backup_controller_page_total_sub".tr(),
-              info: ref.watch(backupProvider).availableAlbums.isEmpty
-                  ? "..."
-                  : "${backupState.allUniqueAssets.length}",
-            ),
-            BackupInfoCard(
-              title: "backup_controller_page_backup".tr(),
-              subtitle: "backup_controller_page_backup_sub".tr(),
-              info: ref.watch(backupProvider).availableAlbums.isEmpty
-                  ? "..."
-                  : "${backupState.selectedAlbumsBackupAssetsIds.length}",
-            ),
-            BackupInfoCard(
-              title: "backup_controller_page_remainder".tr(),
-              subtitle: "backup_controller_page_remainder_sub".tr(),
-              info: ref.watch(backupProvider).availableAlbums.isEmpty
-                  ? "..."
-                  : "${backupState.allUniqueAssets.length - backupState.selectedAlbumsBackupAssetsIds.length}",
-            ),
-            const Divider(),
-            buildAutoBackupController(),
-            const Divider(),
-            AnimatedSwitcher(
-              duration: const Duration(milliseconds: 500),
-              child: Platform.isIOS
-                  ? (appRefreshDisabled
-                      ? buildBackgroundAppRefreshWarning()
-                      : buildBackgroundBackupController())
-                  : buildBackgroundBackupController(),
-            ),
-            if (showBackupFix) const Divider(),
-            if (showBackupFix) buildCheckCorruptBackups(),
-            const Divider(),
-            const Divider(),
-            const CurrentUploadingAssetInfoBox(),
-            if (!hasExclusiveAccess) buildBackgroundBackupInfo(),
-            buildBackupButton(),
-          ],
+          children: hasAnyAlbum
+              ? [
+                  buildFolderSelectionTile(),
+                  BackupInfoCard(
+                    title: "backup_controller_page_total".tr(),
+                    subtitle: "backup_controller_page_total_sub".tr(),
+                    info: ref.watch(backupProvider).availableAlbums.isEmpty
+                        ? "..."
+                        : "${backupState.allUniqueAssets.length}",
+                  ),
+                  BackupInfoCard(
+                    title: "backup_controller_page_backup".tr(),
+                    subtitle: "backup_controller_page_backup_sub".tr(),
+                    info: ref.watch(backupProvider).availableAlbums.isEmpty
+                        ? "..."
+                        : "${backupState.selectedAlbumsBackupAssetsIds.length}",
+                  ),
+                  BackupInfoCard(
+                    title: "backup_controller_page_remainder".tr(),
+                    subtitle: "backup_controller_page_remainder_sub".tr(),
+                    info: ref.watch(backupProvider).availableAlbums.isEmpty
+                        ? "..."
+                        : "${backupState.allUniqueAssets.length - backupState.selectedAlbumsBackupAssetsIds.length}",
+                  ),
+                  const Divider(),
+                  buildAutoBackupController(),
+                  const Divider(),
+                  AnimatedSwitcher(
+                    duration: const Duration(milliseconds: 500),
+                    child: Platform.isIOS
+                        ? (appRefreshDisabled
+                            ? buildBackgroundAppRefreshWarning()
+                            : buildBackgroundBackupController())
+                        : buildBackgroundBackupController(),
+                  ),
+                  if (showBackupFix) const Divider(),
+                  if (showBackupFix) buildCheckCorruptBackups(),
+                  const Divider(),
+                  const Divider(),
+                  const CurrentUploadingAssetInfoBox(),
+                  if (!hasExclusiveAccess) buildBackgroundBackupInfo(),
+                  buildBackupButton(),
+                ]
+              : [buildFolderSelectionTile()],
         ),
       ),
     );