refactor: replace link-button component with immich-ui buttons (#15374)

* refactor: replace link-button component with immich-ui buttons

* minor styling tweak

---------

Co-authored-by: Alex Tran <alex.tran1502@gmail.com>

web/src/lib/components/album-page/albums-controls.svelte

@@ -1,15 +1,30 @@
 <script lang="ts">
-  import LinkButton from '$lib/components/elements/buttons/link-button.svelte';
   import Dropdown from '$lib/components/elements/dropdown.svelte';
+  import GroupTab from '$lib/components/elements/group-tab.svelte';
   import Icon from '$lib/components/elements/icon.svelte';
+  import SearchBar from '$lib/components/elements/search-bar.svelte';
   import {
     AlbumFilter,
-    AlbumSortBy,
     AlbumGroupBy,
+    AlbumSortBy,
     AlbumViewMode,
     albumViewSettings,
     SortOrder,
   } from '$lib/stores/preferences.store';
+  import {
+    type AlbumGroupOptionMetadata,
+    type AlbumSortOptionMetadata,
+    collapseAllAlbumGroups,
+    createAlbumAndRedirect,
+    expandAllAlbumGroups,
+    findFilterOption,
+    findGroupOptionMetadata,
+    findSortOptionMetadata,
+    getSelectedAlbumGroupOption,
+    groupOptionsMetadata,
+    sortOptionsMetadata,
+  } from '$lib/utils/album-utils';
+  import { Button, IconButton, Text } from '@immich/ui';
   import {
     mdiArrowDownThin,
     mdiArrowUpThin,
@@ -22,21 +37,8 @@
     mdiUnfoldMoreHorizontal,
     mdiViewGridOutline,
   } from '@mdi/js';
-  import {
-    type AlbumGroupOptionMetadata,
-    type AlbumSortOptionMetadata,
-    findGroupOptionMetadata,
-    findFilterOption,
-    findSortOptionMetadata,
-    getSelectedAlbumGroupOption,
-    groupOptionsMetadata,
-    sortOptionsMetadata,
-  } from '$lib/utils/album-utils';
-  import SearchBar from '$lib/components/elements/search-bar.svelte';
-  import GroupTab from '$lib/components/elements/group-tab.svelte';
-  import { createAlbumAndRedirect, collapseAllAlbumGroups, expandAllAlbumGroups } from '$lib/utils/album-utils';
-  import { fly } from 'svelte/transition';
   import { t } from 'svelte-i18n';
+  import { fly } from 'svelte/transition';
 
   interface Props {
     albumGroups: string[];
@@ -127,12 +129,10 @@
 </div>
 
 <!-- Create Album -->
-<LinkButton onclick={() => createAlbumAndRedirect()}>
-  <div class="flex place-items-center gap-2 text-sm">
-    <Icon path={mdiPlusBoxOutline} size="18" />
-    <p class="hidden md:block">{$t('create_album')}</p>
-  </div>
-</LinkButton>
+<Button onclick={() => createAlbumAndRedirect()} size="small" variant="ghost" color="secondary">
+  <Icon path={mdiPlusBoxOutline} />
+  <p class="hidden md:block">{$t('create_album')}</p>
+</Button>
 
 <!-- Sort Albums -->
 <Dropdown
@@ -164,34 +164,38 @@
     <!-- Expand Album Groups -->
     <div class="hidden xl:flex gap-0">
       <div class="block">
-        <LinkButton title={$t('expand_all')} onclick={() => expandAllAlbumGroups()}>
-          <div class="flex place-items-center gap-2 text-sm">
-            <Icon path={mdiUnfoldMoreHorizontal} size="18" />
-          </div>
-        </LinkButton>
+        <IconButton
+          title={$t('expand_all')}
+          onclick={() => expandAllAlbumGroups()}
+          variant="ghost"
+          color="secondary"
+          shape="round"
+          icon={mdiUnfoldMoreHorizontal}
+        />
       </div>
 
       <!-- Collapse Album Groups -->
       <div class="block">
-        <LinkButton title={$t('collapse_all')} onclick={() => collapseAllAlbumGroups(albumGroups)}>
-          <div class="flex place-items-center gap-2 text-sm">
-            <Icon path={mdiUnfoldLessHorizontal} size="18" />
-          </div>
-        </LinkButton>
+        <IconButton
+          title={$t('collapse_all')}
+          onclick={() => collapseAllAlbumGroups(albumGroups)}
+          variant="ghost"
+          color="secondary"
+          shape="round"
+          icon={mdiUnfoldLessHorizontal}
+        />
       </div>
     </div>
   </span>
 {/if}
 
 <!-- Cover/List Display Toggle -->
-<LinkButton onclick={() => handleChangeListMode()}>
-  <div class="flex place-items-center gap-2 text-sm">
-    {#if $albumViewSettings.view === AlbumViewMode.List}
-      <Icon path={mdiViewGridOutline} size="18" />
-      <p class="hidden md:block">{$t('covers')}</p>
-    {:else}
-      <Icon path={mdiFormatListBulletedSquare} size="18" />
-      <p class="hidden md:block">{$t('list')}</p>
-    {/if}
-  </div>
-</LinkButton>
+<Button onclick={() => handleChangeListMode()} size="small" variant="ghost" color="secondary">
+  {#if $albumViewSettings.view === AlbumViewMode.List}
+    <Icon path={mdiViewGridOutline} />
+    <Text class="hidden md:block">{$t('covers')}</Text>
+  {:else}
+    <Icon path={mdiFormatListBulletedSquare} size="18" />
+    <Text class="hidden md:block">{$t('list')}</Text>
+  {/if}
+</Button>

web/src/lib/components/elements/buttons/link-button.svelte

@@ -1,25 +0,0 @@
-<script lang="ts" module>
-  export type Color = 'transparent-primary' | 'transparent-gray';
-</script>
-
-<script lang="ts">
-  import Button from '$lib/components/elements/buttons/button.svelte';
-  import type { Snippet } from 'svelte';
-
-  interface Props {
-    href?: string;
-    color?: Color;
-    children?: Snippet;
-    onclick?: (e: MouseEvent) => void;
-    title?: string;
-    disabled?: boolean;
-    fullwidth?: boolean;
-    class?: string;
-  }
-
-  let { color = 'transparent-gray', children, ...rest }: Props = $props();
-</script>
-
-<Button size="link" {color} shadow={false} rounded="lg" {...rest}>
-  {@render children?.()}
-</Button>

web/src/lib/components/elements/dropdown.svelte

@@ -11,14 +11,12 @@
 </script>
 
 <script lang="ts" generics="T">
-  import Icon from './icon.svelte';
-
-  import { mdiCheck } from '@mdi/js';
-
-  import { isEqual } from 'lodash-es';
-  import LinkButton from './buttons/link-button.svelte';
   import { clickOutside } from '$lib/actions/click-outside';
+  import { Button, Text } from '@immich/ui';
+  import { mdiCheck } from '@mdi/js';
+  import { isEqual } from 'lodash-es';
   import { fly } from 'svelte/transition';
+  import Icon from './icon.svelte';
 
   interface Props {
     class?: string;
@@ -82,14 +80,12 @@
 
 <div use:clickOutside={{ onOutclick: handleClickOutside, onEscape: handleClickOutside }}>
   <!-- BUTTON TITLE -->
-  <LinkButton onclick={() => (showMenu = true)} fullwidth {title}>
-    <div class="flex place-items-center gap-2 text-sm">
-      {#if renderedSelectedOption?.icon}
-        <Icon path={renderedSelectedOption.icon} size="18" />
-      {/if}
-      <p class={hideTextOnSmallScreen ? 'hidden sm:block' : ''}>{renderedSelectedOption.title}</p>
-    </div>
-  </LinkButton>
+  <Button onclick={() => (showMenu = true)} fullWidth {title} variant="ghost" color="secondary" size="small">
+    {#if renderedSelectedOption?.icon}
+      <Icon path={renderedSelectedOption.icon} />
+    {/if}
+    <Text class={hideTextOnSmallScreen ? 'hidden sm:block' : ''}>{renderedSelectedOption.title}</Text>
+  </Button>
 
   <!-- DROP DOWN MENU -->
   {#if showMenu}
@@ -108,7 +104,7 @@
         >
           {#if isEqual(selectedOption, option)}
             <div class="text-immich-primary dark:text-immich-dark-primary">
-              <Icon path={mdiCheck} size="18" />
+              <Icon path={mdiCheck} />
             </div>
             <p class="justify-self-start text-immich-primary dark:text-immich-dark-primary">
               {renderedOption.title}

web/src/lib/components/map-page/map-settings-modal.svelte

@@ -1,13 +1,11 @@
 <script lang="ts">
   import FullScreenModal from '$lib/components/shared-components/full-screen-modal.svelte';
   import SettingSelect from '$lib/components/shared-components/settings/setting-select.svelte';
-  import SettingSwitch from '$lib/components/shared-components/settings/setting-switch.svelte';
   import type { MapSettings } from '$lib/stores/preferences.store';
+  import { Button, Field, Stack, Switch } from '@immich/ui';
   import { Duration } from 'luxon';
   import { t } from 'svelte-i18n';
   import { fly } from 'svelte/transition';
-  import Button from '../elements/buttons/button.svelte';
-  import LinkButton from '../elements/buttons/link-button.svelte';
   import DateInput from '../elements/date-input.svelte';
 
   interface Props {
@@ -16,7 +14,8 @@
     onSave: (settings: MapSettings) => void;
   }
 
-  let { settings = $bindable(), onClose, onSave }: Props = $props();
+  let { settings: initialValues, onClose, onSave }: Props = $props();
+  let settings = $state(initialValues);
 
   let customDateRange = $state(!!settings.dateAfter || !!settings.dateBefore);
 
@@ -26,90 +25,109 @@
   };
 </script>
 
-<FullScreenModal title={$t('map_settings')} {onClose}>
-  <form {onsubmit} class="flex flex-col gap-4 text-immich-primary dark:text-immich-dark-primary" id="map-settings-form">
-    <SettingSwitch title={$t('allow_dark_mode')} bind:checked={settings.allowDarkMode} />
-    <SettingSwitch title={$t('only_favorites')} bind:checked={settings.onlyFavorites} />
-    <SettingSwitch title={$t('include_archived')} bind:checked={settings.includeArchived} />
-    <SettingSwitch title={$t('include_shared_partner_assets')} bind:checked={settings.withPartners} />
-    <SettingSwitch title={$t('include_shared_albums')} bind:checked={settings.withSharedAlbums} />
-    {#if customDateRange}
-      <div in:fly={{ y: 10, duration: 200 }} class="flex flex-col gap-4">
-        <div class="flex items-center justify-between gap-8">
-          <label class="immich-form-label shrink-0 text-sm" for="date-after">{$t('date_after')}</label>
-          <DateInput
-            class="immich-form-input w-40"
-            type="date"
-            id="date-after"
-            max={settings.dateBefore}
-            bind:value={settings.dateAfter}
-          />
-        </div>
-        <div class="flex items-center justify-between gap-8">
-          <label class="immich-form-label shrink-0 text-sm" for="date-before">{$t('date_before')}</label>
-          <DateInput class="immich-form-input w-40" type="date" id="date-before" bind:value={settings.dateBefore} />
-        </div>
-        <div class="flex justify-center text-xs">
-          <LinkButton
-            onclick={() => {
-              customDateRange = false;
-              settings.dateAfter = '';
-              settings.dateBefore = '';
-            }}
-          >
-            {$t('remove_custom_date_range')}
-          </LinkButton>
-        </div>
-      </div>
-    {:else}
-      <div in:fly={{ y: -10, duration: 200 }} class="flex flex-col gap-1">
-        <SettingSelect
-          label={$t('date_range')}
-          name="date-range"
-          bind:value={settings.relativeDate}
-          options={[
-            {
-              value: '',
-              text: $t('all'),
-            },
-            {
-              value: Duration.fromObject({ hours: 24 }).toISO() || '',
-              text: $t('past_durations.hours', { values: { hours: 24 } }),
-            },
-            {
-              value: Duration.fromObject({ days: 7 }).toISO() || '',
-              text: $t('past_durations.days', { values: { days: 7 } }),
-            },
-            {
-              value: Duration.fromObject({ days: 30 }).toISO() || '',
-              text: $t('past_durations.days', { values: { days: 30 } }),
-            },
-            {
-              value: Duration.fromObject({ years: 1 }).toISO() || '',
-              text: $t('past_durations.years', { values: { years: 1 } }),
-            },
-            {
-              value: Duration.fromObject({ years: 3 }).toISO() || '',
-              text: $t('past_durations.years', { values: { years: 3 } }),
-            },
-          ]}
-        />
-        <div class="text-xs">
-          <LinkButton
-            onclick={() => {
-              customDateRange = true;
-              settings.relativeDate = '';
-            }}
-          >
-            {$t('use_custom_date_range')}
-          </LinkButton>
-        </div>
-      </div>
-    {/if}
-  </form>
+<form {onsubmit}>
+  <FullScreenModal title={$t('map_settings')} {onClose}>
+    <Stack gap={4}>
+      <Field label={$t('allow_dark_mode')}>
+        <Switch bind:checked={settings.allowDarkMode} class="flex justify-between items-center text-sm" />
+      </Field>
+      <Field label={$t('only_favorites')}>
+        <Switch bind:checked={settings.onlyFavorites} class="flex justify-between items-center text-sm" />
+      </Field>
+      <Field label={$t('include_archived')}>
+        <Switch bind:checked={settings.includeArchived} class="flex justify-between items-center text-sm" />
+      </Field>
+      <Field label={$t('include_shared_partner_assets')}>
+        <Switch bind:checked={settings.withPartners} class="flex justify-between items-center text-sm" />
+      </Field>
+      <Field label={$t('include_shared_albums')}>
+        <Switch bind:checked={settings.withSharedAlbums} class="flex justify-between items-center text-sm" />
+      </Field>
 
-  {#snippet stickyBottom()}
-    <Button color="gray" size="sm" fullwidth onclick={onClose}>{$t('cancel')}</Button>
-    <Button type="submit" size="sm" fullwidth form="map-settings-form">{$t('save')}</Button>
-  {/snippet}
-</FullScreenModal>
+      {#if customDateRange}
+        <div in:fly={{ y: 10, duration: 200 }} class="flex flex-col gap-4">
+          <div class="flex items-center justify-between gap-8">
+            <label class="immich-form-label shrink-0 text-sm" for="date-after">{$t('date_after')}</label>
+            <DateInput
+              class="immich-form-input w-40"
+              type="date"
+              id="date-after"
+              max={settings.dateBefore}
+              bind:value={settings.dateAfter}
+            />
+          </div>
+          <div class="flex items-center justify-between gap-8">
+            <label class="immich-form-label shrink-0 text-sm" for="date-before">{$t('date_before')}</label>
+            <DateInput class="immich-form-input w-40" type="date" id="date-before" bind:value={settings.dateBefore} />
+          </div>
+          <div class="flex justify-center text-xs">
+            <Button
+              color="primary"
+              size="small"
+              variant="ghost"
+              onclick={() => {
+                customDateRange = false;
+                settings.dateAfter = '';
+                settings.dateBefore = '';
+              }}
+            >
+              {$t('remove_custom_date_range')}
+            </Button>
+          </div>
+        </div>
+      {:else}
+        <div in:fly={{ y: -10, duration: 200 }} class="flex flex-col gap-1">
+          <SettingSelect
+            label={$t('date_range')}
+            name="date-range"
+            bind:value={settings.relativeDate}
+            options={[
+              {
+                value: '',
+                text: $t('all'),
+              },
+              {
+                value: Duration.fromObject({ hours: 24 }).toISO() || '',
+                text: $t('past_durations.hours', { values: { hours: 24 } }),
+              },
+              {
+                value: Duration.fromObject({ days: 7 }).toISO() || '',
+                text: $t('past_durations.days', { values: { days: 7 } }),
+              },
+              {
+                value: Duration.fromObject({ days: 30 }).toISO() || '',
+                text: $t('past_durations.days', { values: { days: 30 } }),
+              },
+              {
+                value: Duration.fromObject({ years: 1 }).toISO() || '',
+                text: $t('past_durations.years', { values: { years: 1 } }),
+              },
+              {
+                value: Duration.fromObject({ years: 3 }).toISO() || '',
+                text: $t('past_durations.years', { values: { years: 3 } }),
+              },
+            ]}
+          />
+          <div class="text-xs">
+            <Button
+              color="primary"
+              size="small"
+              variant="ghost"
+              onclick={() => {
+                customDateRange = true;
+                settings.relativeDate = '';
+              }}
+            >
+              {$t('use_custom_date_range')}
+            </Button>
+          </div>
+        </div>
+      {/if}
+    </Stack>
+
+    {#snippet stickyBottom()}
+      <Button color="secondary" shape="round" fullWidth onclick={onClose}>{$t('cancel')}</Button>
+      <Button type="submit" shape="round" fullWidth>{$t('save')}</Button>
+    {/snippet}
+  </FullScreenModal>
+</form>

web/src/lib/components/shared-components/create-share-link-modal/create-shared-link-modal.svelte

@@ -1,21 +1,20 @@
 <script lang="ts">
   import Button from '$lib/components/elements/buttons/button.svelte';
-  import LinkButton from '$lib/components/elements/buttons/link-button.svelte';
-  import Icon from '$lib/components/elements/icon.svelte';
+  import FullScreenModal from '$lib/components/shared-components/full-screen-modal.svelte';
+  import SettingSelect from '$lib/components/shared-components/settings/setting-select.svelte';
+  import { SettingInputFieldType } from '$lib/constants';
+  import { locale } from '$lib/stores/preferences.store';
   import { serverConfig } from '$lib/stores/server-config.store';
   import { copyToClipboard, makeSharedLinkUrl } from '$lib/utils';
   import { handleError } from '$lib/utils/handle-error';
   import { SharedLinkType, createSharedLink, updateSharedLink, type SharedLinkResponseDto } from '@immich/sdk';
+  import { HStack, IconButton, Input } from '@immich/ui';
   import { mdiContentCopy, mdiLink } from '@mdi/js';
+  import { DateTime, Duration } from 'luxon';
+  import { t } from 'svelte-i18n';
   import { NotificationType, notificationController } from '../notification/notification';
   import SettingInputField from '../settings/setting-input-field.svelte';
   import SettingSwitch from '../settings/setting-switch.svelte';
-  import FullScreenModal from '$lib/components/shared-components/full-screen-modal.svelte';
-  import { t } from 'svelte-i18n';
-  import { locale } from '$lib/stores/preferences.store';
-  import { DateTime, Duration } from 'luxon';
-  import SettingSelect from '$lib/components/shared-components/settings/setting-select.svelte';
-  import { SettingInputFieldType } from '$lib/constants';
 
   interface Props {
     onClose: () => void;
@@ -243,14 +242,18 @@
         <Button size="sm" fullwidth onclick={handleCreateSharedLink}>{$t('create_link')}</Button>
       {/if}
     {:else}
-      <div class="flex w-full gap-2">
-        <input class="immich-form-input w-full" bind:value={sharedLink} disabled />
-        <LinkButton onclick={() => (sharedLink ? copyToClipboard(sharedLink) : '')}>
-          <div class="flex place-items-center gap-2 text-sm">
-            <Icon path={mdiContentCopy} ariaLabel={$t('copy_link_to_clipboard')} size="18" />
-          </div>
-        </LinkButton>
-      </div>
+      <HStack class="w-full">
+        <Input bind:value={sharedLink} disabled class="flex flex-row" />
+        <IconButton
+          variant="ghost"
+          shape="round"
+          color="secondary"
+          size="giant"
+          icon={mdiContentCopy}
+          onclick={() => (sharedLink ? copyToClipboard(sharedLink) : '')}
+          aria-label={$t('copy_link_to_clipboard')}
+        />
+      </HStack>
     {/if}
   {/snippet}
 </FullScreenModal>

web/src/lib/components/shared-components/navigation-bar/navigation-bar.svelte

@@ -2,25 +2,25 @@
   import { page } from '$app/state';
   import { clickOutside } from '$lib/actions/click-outside';
   import CircleIconButton from '$lib/components/elements/buttons/circle-icon-button.svelte';
-  import LinkButton from '$lib/components/elements/buttons/link-button.svelte';
   import SkipLink from '$lib/components/elements/buttons/skip-link.svelte';
   import Icon from '$lib/components/elements/icon.svelte';
+  import HelpAndFeedbackModal from '$lib/components/shared-components/help-and-feedback-modal.svelte';
+  import ImmichLogo from '$lib/components/shared-components/immich-logo.svelte';
+  import SearchBar from '$lib/components/shared-components/search-bar/search-bar.svelte';
+  import { AppRoute } from '$lib/constants';
   import { featureFlags } from '$lib/stores/server-config.store';
   import { user } from '$lib/stores/user.store';
   import { userInteraction } from '$lib/stores/user.svelte';
   import { handleLogout } from '$lib/utils/auth';
   import { getAboutInfo, logout, type ServerAboutResponseDto } from '@immich/sdk';
+  import { Button, IconButton } from '@immich/ui';
   import { mdiHelpCircleOutline, mdiMagnify, mdiTrayArrowUp } from '@mdi/js';
+  import { onMount } from 'svelte';
   import { t } from 'svelte-i18n';
   import { fade } from 'svelte/transition';
-  import { AppRoute } from '$lib/constants';
-  import ImmichLogo from '$lib/components/shared-components/immich-logo.svelte';
-  import SearchBar from '$lib/components/shared-components/search-bar/search-bar.svelte';
   import ThemeButton from '../theme-button.svelte';
   import UserAvatar from '../user-avatar.svelte';
   import AccountInfoPanel from './account-info-panel.svelte';
-  import HelpAndFeedbackModal from '$lib/components/shared-components/help-and-feedback-modal.svelte';
-  import { onMount } from 'svelte';
 
   interface Props {
     showUploadButton?: boolean;
@@ -87,22 +87,24 @@
             onEscape: () => (shouldShowHelpPanel = false),
           }}
         >
-          <CircleIconButton
-            id="support-feedback-button"
+          <IconButton
+            shape="round"
+            color="secondary"
+            variant="ghost"
+            size="large"
             title={$t('support_and_feedback')}
             icon={mdiHelpCircleOutline}
             onclick={() => (shouldShowHelpPanel = !shouldShowHelpPanel)}
-            padding="1"
           />
         </div>
 
         {#if !page.url.pathname.includes('/admin') && showUploadButton}
-          <LinkButton onclick={onUploadClick} class="hidden lg:block">
+          <Button onclick={onUploadClick} class="hidden lg:block" variant="ghost" color="secondary">
             <div class="flex gap-2">
               <Icon path={mdiTrayArrowUp} size="1.5em" />
               <span>{$t('upload')}</span>
             </div>
-          </LinkButton>
+          </Button>
           <CircleIconButton
             onclick={onUploadClick}
             title={$t('upload')}