helpy4/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich synced 2025-11-07 17:27:20 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

refactor: job create modal (#18106)

Browse source 
* refactor: job create modal

* chore: better modal manager types (#18107)
This commit is contained in:
Daniel Dietzler 2025-05-06 14:44:44 +02:00 • committed by GitHub
parent 33f3751b72
commit 1138f6dcce
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
4 changed files with 83 additions and 68 deletions
Download patch file Download diff file Expand all files Collapse all files

11
web/src/lib/managers/modal-manager.svelte.ts
View file

@ -2,11 +2,14 @@ import ConfirmDialog from '$lib/components/shared-components/dialog/confirm-dial
import { mount, unmount, type Component, type ComponentProps } from 'svelte';
type OnCloseData<T> = T extends { onClose: (data: infer R) => void } ? R : never;
// TODO make `props` optional if component only has `onClose`
// type OptionalIfEmpty<T extends object> = keyof T extends never ? undefined : T;
type OptionalIfEmpty<T extends object> = keyof T extends never ? undefined : T;
class ModalManager {
open<T extends object, K = OnCloseData<T>>(Component: Component<T>, props: Omit<T, 'onClose'>) {
open<T extends object, K = OnCloseData<T>>(
Component: Component<T>,
props?: OptionalIfEmpty<Omit<T, 'onClose'>> | Record<string, never>,
): Promise<K>;
open<T extends object, K = OnCloseData<T>>(Component: Component<T>, props: OptionalIfEmpty<Omit<T, 'onClose'>>) {
return new Promise<K>((resolve) => {
let modal: object = {};
@ -18,7 +21,7 @@ class ModalManager {
modal = mount(Component, {
target: document.body,
props: {
...(props as T),
...((props ?? {}) as T),
onClose,
},
});