fix(web,a11y): remove autofocus from input fields (#8857)

* fix(web,a11y): remove autofocus from input field

The autofocus attribute can cause the keyboard to unexpectedly appear
for mobile users, and override any other focus management that the
application is doing programatically.

* fix: always include people filter
This commit is contained in:
Ben 2024-04-17 09:15:37 +00:00 committed by GitHub
parent f58886514d
commit 1071396a4a
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 13 additions and 11 deletions

View file

@ -1,6 +1,6 @@
<script lang="ts">
import { type PersonResponseDto } from '@immich/sdk';
import { createEventDispatcher } from 'svelte';
import { createEventDispatcher, onMount } from 'svelte';
import ImageThumbnail from '../assets/thumbnail/image-thumbnail.svelte';
import Button from '../elements/buttons/button.svelte';
@ -9,11 +9,17 @@
export let suggestedPeople = false;
export let thumbnailData: string;
let inputElement: HTMLInputElement;
const dispatch = createEventDispatcher<{
change: string;
cancel: void;
input: void;
}>();
onMount(() => {
inputElement.focus();
});
</script>
<div
@ -27,13 +33,12 @@
autocomplete="off"
on:submit|preventDefault={() => dispatch('change', name)}
>
<!-- svelte-ignore a11y-autofocus -->
<input
autofocus
class="w-full gap-2 bg-gray-100 dark:bg-gray-700 dark:text-white"
type="text"
placeholder="New name or nickname"
bind:value={name}
bind:this={inputElement}
on:input={() => dispatch('input')}
/>
<Button size="sm" type="submit">Done</Button>