helpy4/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich synced 2026-08-22 13:13:05 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

Merge 328a1e409d into 652ef8a427

Browse source
This commit is contained in:
Mees Frensel 2026-08-14 11:02:38 -04:00 • committed by GitHub
commit 0ea6f456f2
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
4 changed files with 13 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

2
i18n/en.json
View file

@ -446,7 +446,7 @@
"transcoding_temporal_aq": "Temporal AQ",
"transcoding_temporal_aq_description": "Applies only to NVENC. Temporal Adaptive Quantization increases quality of high-detail, low-motion scenes. May not be compatible with older devices.",
"transcoding_threads": "Threads",
"transcoding_threads_description": "Higher values lead to faster encoding, but leave less room for the server to process other tasks while active. This value should not be more than the number of CPU cores. Maximizes utilization if set to 0.",
"transcoding_threads_description": "Higher values lead to faster encoding, but leave less room for the server to process other tasks while active. This value should not be more than the number of CPU cores. Maximizes utilization if set to 0.{av1, select, true { The AV1 encoder uses a number between 1–6 describing the amount of parallelism, instead of limiting to a specific number of threads.} other {}}",
"transcoding_tone_mapping": "Tone-mapping",
"transcoding_tone_mapping_description": "Attempts to preserve the appearance of HDR videos when converted to SDR. Each algorithm makes different tradeoffs for color, detail and brightness. Hable preserves detail, Mobius preserves color, and Reinhard preserves brightness.",
"transcoding_transcode_policy": "Transcode policy",

4
server/src/dtos/system-config.dto.ts
View file

@ -18,6 +18,7 @@ import {
ToneMappingSchema,
TranscodeHardwareAccelerationSchema,
TranscodePolicySchema,
VideoCodec,
VideoCodecSchema,
VideoContainerSchema,
} from 'src/enum';
@ -126,6 +127,9 @@ const SystemConfigFFmpegSchema = z
})
.meta({ id: 'SystemConfigFFmpegRealtimeDto' }),
})
.refine((ffmpeg) => (ffmpeg.targetVideoCodec === VideoCodec.Av1 ? ffmpeg.threads <= 6 : true), {
error: 'Threads: for AV1, parallelism must be 0–6',
})
.meta({ id: 'SystemConfigFFmpegDto' });
const SystemConfigJobSchema = z

5
server/src/services/system-config.service.spec.ts
View file

@ -459,6 +459,11 @@ describe(SystemConfigService.name, () => {
},
{ should: 'warn for top level unknown options', warn: true, config: { unknownOption: true } },
{ should: 'warn for nested unknown options', warn: true, config: { ffmpeg: { unknownOption: true } } },
{
should: 'validate av1 parallelism setting',
config: { ffmpeg: { targetVideoCodec: VideoCodec.Av1, threads: 7 } },
throws: '[ffmpeg] Threads: for AV1, parallelism must be 0–6',
},
];
for (const test of tests) {

4
web/src/routes/admin/system-settings/FFmpegSettings.svelte
View file

@ -241,7 +241,9 @@
inputType={SettingInputFieldType.NUMBER}
{disabled}
label={$t('admin.transcoding_threads')}
description={$t('admin.transcoding_threads_description')}
description={$t('admin.transcoding_threads_description', {
values: { av1: configToEdit.ffmpeg.targetVideoCodec === VideoCodec.Av1 },
})}
bind:value={configToEdit.ffmpeg.threads}
isEdited={configToEdit.ffmpeg.threads !== config.ffmpeg.threads}
/>