mirror of
https://github.com/MCCTeam/Minecraft-Console-Client
synced 2026-08-15 13:04:36 +00:00
Audited all 8 high-complexity structured components against official 1.20.6 decompiled STREAM_CODEC definitions. Found and fixed bugs in 3 components plus a systemic NBT serialization issue: TrimComponent (ID 35): - Serialize had TrimPatternType and ShowInTooltip incorrectly nested inside the TrimMaterialType==0 branch; moved them outside to match Parse logic - Description fields (TrimMaterial.description, TrimPattern.description) were read/written as String but official codec uses ComponentSerialization (NBT Tag format); changed to ReadNextNbt/GetNbt ProfileComponent (ID 46): - Serialize was missing the HasUniqueId Bool prefix before UUID - Serialize only wrote properties when count > 0 but omitted the VarInt count prefix entirely when empty; now always writes VarInt count WrittenBookContentComponent (ID 34): - Page content uses Filterable<Component> where Component is NBT-encoded via ComponentSerialization.STREAM_CODEC, not plain String; changed Parse to use ReadNextNbt and Serialize to use GetNbt - Added RawContentNbt/FilteredContentNbt fields to BookPage record for round-trip NBT preservation - Removed unnecessary ChatParser.ParseText on title (it's a plain string) DataTypes.GetNbt: - Added TAG_String root support for 1.20.4+ (chat components like "Page 1" are encoded as TAG_String, not TAG_Compound) - Fixed root name handling: versions >= 1.20.2 omit the root compound name, but GetNbt was unconditionally writing it Components confirmed correct (no changes needed): - FoodComponentComponent (ID 20), ToolComponent (ID 22), InstrumentComponent (ID 40), PotionContentsComponent (ID 31), AttributeModifiersComponent (ID 12) Made-with: Cursor |
||
|---|---|---|
| .. | ||
| ItemPalettes | ||
| BookPage.cs | ||
| Container.cs | ||
| ContainerExtensions.cs | ||
| ContainerType.cs | ||
| ContainerTypeExtensions.cs | ||
| Effects.cs | ||
| Enchantment.cs | ||
| EnchantmentData.cs | ||
| EnchantmentMapping.cs | ||
| EnchantmentPropertyInfo.cs | ||
| Enchantments.cs | ||
| Hand.cs | ||
| Item.cs | ||
| ItemMovingHelper.cs | ||
| ItemRarity.cs | ||
| ItemType.cs | ||
| ItemTypeExtensions.cs | ||
| SuspiciousStewEffect.cs | ||
| TrimAssetOverride.cs | ||
| VillagerInfo.cs | ||
| VillagerTrade.cs | ||
| WindowActionType.cs | ||