Two critical issues in the 1.20.6 configuration phase that could cause
connection instability and packet desync:
1. RegistryData: The handler used an early `break` when it encountered
a registryId other than "minecraft:dimension_type" or
"minecraft:chat_type". This skipped reading the remaining entries
for that registry, leaving unconsumed data in the packet buffer.
Subsequent packet reads would start at the wrong offset, causing
cascading parse failures and eventual disconnection.
Fix: Always read all entries (entryId + hasData + optional NBT)
for every registry, regardless of whether we process it. For
dimension_type entries, if the server sends inline NBT data (i.e.
non-vanilla dimensions from mods/datapacks), parse and store
the dimension directly via World.StoreOneDimension(). Only fall
back to hardcoded defaults when no dimension data was received.
2. KnownDataPacks: The client echoed back ALL packs the server
listed, including non-vanilla ones. This told the server "I have
these packs cached" when the client actually did not, so the
server would skip sending full registry data for those packs.
The result: incomplete registries for modded/datapack content.
Fix: Filter the response to only include packs with the
"minecraft" namespace. Non-vanilla packs are omitted, forcing
the server to send their full registry data inline.
Also adds supporting methods to World.cs:
- SetDimensionIdMap(): Store VarInt ID -> dimension name mapping
from RegistryData entries (needed by JoinGame/Respawn)
- GetDimensionNameById(): Look up dimension name by numeric ID
- HasAnyDimension(): Check if any dimensions were loaded from
server-provided data
Made-with: Cursor
The 1.20.6 EntityProperties packet sends attribute IDs as VarInts
instead of strings. The existing mapping dictionary had three issues:
1. IDs 5/6/7 used the wrong prefix "generic." but the official
1.20.6 registry uses "player." for these attributes:
- 5: player.block_break_speed (was generic.block_break_speed)
- 6: player.block_interaction_range (was generic.block_interaction_range)
- 7: player.entity_interaction_range (was generic.entity_interaction_range)
2. IDs 22-24 (submerged_mining_speed, sweeping_damage_ratio,
water_movement_efficiency) do not exist in the 1.20.6 attribute
registry — they were introduced in 1.21. Their presence could
cause incorrect attribute resolution.
3. Direct dictionary indexing (attributeDictionary[id]) throws
KeyNotFoundException if the server sends an unknown attribute ID,
crashing the packet handler. Replaced with TryGetValue and a
safe fallback to "unknown".
Made-with: Cursor
When MCC runs in non-interactive terminals (e.g. CI runners, IDE
embedded shells, piped input), several Console APIs throw exceptions
because there is no real console attached.
Changes:
- Program.cs: Wrap Console.KeyAvailable / Console.ReadKey in
HandleFailure() with try-catch so MCC does not crash on startup
failure in headless environments.
- Chunk.cs: Wrap Console.BufferWidth / BufferHeight in try-catch
with fallback values (120x50) to prevent exceptions when rendering
chunk maps without a console buffer.
- Map.cs: Same treatment for the map rendering path - use safe
fallback values when Console.BufferWidth/Height are unavailable.
- ReplayHandler.cs: Replace Array.Reverse() (returns void in newer
.NET) with .AsEnumerable().Reverse() to fix compilation with
.NET 10 SDK where the void return breaks the fluent chain.
Made-with: Cursor
* add miscellaneous fixes
* Fixed connecting to server when compression threshold is set to 0
The client assumes that 0 means disabled, when on a notchian (vanilla) server, it is possible to set the compression threshold to 0 (compress all packets).
* Try to capture all exceptions through Sentry
No exceptions are being logged through Sentry, so be more aggressive when sending exceptions
(cherry picked from commit eb1c2f5e771760fb3be32ffea79f8292adca92f1)
* Call OnSpawnPlayer packet when a player is spawned using the SpawnEntity packet
references #2721
(cherry picked from commit ef28ae09ac89e8988dd612de61f2849a9f0e528c)
* Add Sentry Error Tracking
* Omit personally identifiable information and add additional sentry context
* Remove debug message
* Make sentry opt-out and add related notices and strings
Also add Minecraft Version to error context
* Update build to send release info to sentry
* Adjust sentry error tracking
- Send the user-friendly Minecraft Version in the error logs
- Capture exceptions in more parts of the application
We now capture exceptions from the following locations:
- Protocol18 (1.8+) Packet errors
- Errors during client initialization phase (When client is about to start, session keys are NEVER sent to sentry)
* Make Sentry DSN configurable and repository-specific
The Sentry DSN will automatically be filled out on the main repository through the Github Actions build.
* Update build-and-release.yml
Update sed command
* style: change variable name
nitpick, just to make it a little bit more descriptive
* Add Sentry branding in README.
* remove old code (merge conflict)
* Update CI to detect the word "skipci"
* Make script compilation errors more verbose
Rather than just giving the line in which the error has been found, return the actual text content of the line itself
* Attempt to bubble up errors in the script chain, so it says the reason for any NotRun errors.
The exception message gets eaten up when the script is running, and an exception happens.
Also put in a default result message for the CmdResult, instead of having it default to null.
* Trim the whitespace off returned script compilation error line
The fix is to remove the ParseText call from the OnConnectionLost call, as the ReadNextChat function already calls ParseText. Calling ParseText on an unparsable string returns an empty string, therefore the disconnect message never gets propagated to the user.
Makes AutoRelog more hands on with the relogging rather than have the general relogging handler handle it.
Fallback to the general handler only when the AutoRelog module is disabled.
