From dee085686f448e73491f1f4ee5556634f792e6ed Mon Sep 17 00:00:00 2001 From: BruceChen Date: Mon, 10 Oct 2022 15:32:39 +0800 Subject: [PATCH] Try fix BadPackets --- MinecraftClient/Protocol/Handlers/DataTypes.cs | 2 +- MinecraftClient/Protocol/Handlers/Protocol18.cs | 7 ++----- README.md | 8 ++++---- 3 files changed, 7 insertions(+), 10 deletions(-) diff --git a/MinecraftClient/Protocol/Handlers/DataTypes.cs b/MinecraftClient/Protocol/Handlers/DataTypes.cs index d64e75e5..49751548 100644 --- a/MinecraftClient/Protocol/Handlers/DataTypes.cs +++ b/MinecraftClient/Protocol/Handlers/DataTypes.cs @@ -938,7 +938,7 @@ namespace MinecraftClient.Protocol.Handlers { List bytes = new() { - (byte)Convert.ToByte(paramBool) + Convert.ToByte(paramBool) }; return bytes.ToArray(); } diff --git a/MinecraftClient/Protocol/Handlers/Protocol18.cs b/MinecraftClient/Protocol/Handlers/Protocol18.cs index f8f20206..5b00b26e 100644 --- a/MinecraftClient/Protocol/Handlers/Protocol18.cs +++ b/MinecraftClient/Protocol/Handlers/Protocol18.cs @@ -353,8 +353,7 @@ namespace MinecraftClient.Protocol.Handlers handler.OnServerKeepAlive(); break; case PacketTypesIn.Ping: - int ID = dataTypes.ReadNextInt(packetData); - SendPacket(PacketTypesOut.Pong, dataTypes.GetInt(ID)); + SendPacket(PacketTypesOut.Pong, packetData); break; case PacketTypesIn.JoinGame: handler.OnGameJoined(); @@ -1383,10 +1382,8 @@ namespace MinecraftClient.Protocol.Handlers byte windowID = dataTypes.ReadNextByte(packetData); short actionID = dataTypes.ReadNextShort(packetData); bool accepted = dataTypes.ReadNextBool(packetData); - if (!accepted) - { + if (!accepted && actionID > 0) SendWindowConfirmation(windowID, actionID, accepted); - } } break; case PacketTypesIn.ResourcePackSend: diff --git a/README.md b/README.md index d5a5bd5b..4d744f0a 100644 --- a/README.md +++ b/README.md @@ -50,11 +50,11 @@ If you'd like to contribute to Minecraft Console Client, great, just fork the re Check out: [How to update or add translations for MCC](https://mccteam.github.io/guide/contibuting.html#translations). MCC now supports the following languages (Alphabetical order) : - * `de.ini` (57.12% translated) : Deutsch - German + * `de.ini` (54.64% translated) : Deutsch - German * `en.ini` : English - English - * `fr.ini` (57.12% translated) : Français (France) - French - * `ru.ini` (56.18% translated) : Русский (Russkiy) - Russian - * `vi.ini` (56.18% translated) : Tiếng Việt (Việt Nam) - Vietnamese + * `fr.ini` (54.64% translated) : Français (France) - French + * `ru.ini` (53.74% translated) : Русский (Russkiy) - Russian + * `vi.ini` (53.74% translated) : Tiếng Việt (Việt Nam) - Vietnamese * `zh-Hans.ini` (100.00% translated) : 简体中文 - Chinese Simplified * `zh-Hant.ini` (100.00% translated) : 繁體中文 - Chinese Traditional