Small code optimizations

Added statics + check > 0 from pull #10, and small optimization in
FinalizeLogin.
This commit is contained in:
ORelio 2013-07-27 21:31:03 +02:00
parent ea2774068b
commit d6f4b97ffa

View file

@ -435,7 +435,7 @@ namespace MinecraftClient
readData(12 * (chunkcount)); readData(12 * (chunkcount));
} }
private void setcolor(char c) private static void setcolor(char c)
{ {
switch (c) switch (c)
{ {
@ -458,7 +458,7 @@ namespace MinecraftClient
case 'r': Console.ForegroundColor = ConsoleColor.White; break; case 'r': Console.ForegroundColor = ConsoleColor.White; break;
} }
} }
private void printstring(string str, bool acceptnewlines) private static void printstring(string str, bool acceptnewlines)
{ {
if (!String.IsNullOrEmpty(str)) if (!String.IsNullOrEmpty(str))
{ {
@ -682,12 +682,7 @@ namespace MinecraftClient
} }
public bool FinalizeLogin() public bool FinalizeLogin()
{ {
//Creating byte array Send(new byte[] { 0xCD, 0 });
byte[] data = new byte[2];
data[0] = 0xCD;
data[1] = 0;
Send(data);
try try
{ {
byte[] pid = new byte[1]; byte[] pid = new byte[1];
@ -768,9 +763,12 @@ namespace MinecraftClient
Array.Reverse(msglen); Array.Reverse(msglen);
msglen.CopyTo(reason, 1); msglen.CopyTo(reason, 1);
if (message.Length > 0)
{
byte[] msg; byte[] msg;
msg = Encoding.BigEndianUnicode.GetBytes(message); msg = Encoding.BigEndianUnicode.GetBytes(message);
msg.CopyTo(reason, 3); msg.CopyTo(reason, 3);
}
Send(reason); Send(reason);
} }