helpy4/Minecraft-Console-Client
1
0
Fork 0
mirror of https://github.com/MCCTeam/Minecraft-Console-Client synced 2025-10-14 21:22:49 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Improve InvokeOnMainThread mechanism

Browse source 
Add documentation to make the invoke mechanism easier to understand
Make it clear in documentation that code is invoked synchronously
Use Action and Func<T> for minimizing the amount of code to write
Use type parameter T to automatically adjust return value type
Throw exceptions on the calling thread, not the main thread
This commit is contained in:
ORelio 2021-05-15 16:31:02 +02:00
parent 9e5364a4ff
commit c1cfaf520d
6 changed files with 164 additions and 59 deletions
Download patch file Download diff file Expand all files Collapse all files

13
MinecraftClient/ChatBot.cs
View file

@ -1402,12 +1402,13 @@ namespace MinecraftClient
/// Console.WriteLine("10 seconds has passed");
/// }), 100);
/// </example>
protected void ScheduleTaskDelayed(Delegate task, int delayTicks = 0)
// TODO: Adapt to new IMinecraftComHandler API
/*protected void ScheduleTaskDelayed(Delegate task, int delayTicks = 0)
{
if (delayTicks <= 0)
{
// Immediately schedule to run on next update
Handler.ScheduleTask(task);
Handler.InvokeOnMainThread(task);
}
else
{
@ -1416,17 +1417,19 @@ namespace MinecraftClient
delayTasks.Add(new DelayedTask(task, delayTicks));
}
}
}
}*/
/// <summary>
/// Schedule a task to run on main thread.
/// </summary>
/// <param name="task">Task to run</param>
/// <returns>Any value returned from the task</returns>
// TODO: Adapt to new IMinecraftComHandler API
/*
protected object ScheduleTask(Delegate task)
{
return Handler.ScheduleTask(task);
}
return Handler.InvokeOnMainThread(task);
}*/
/// <summary>
/// Command runner definition.