From 981bae184a1505386eb66c41c609ee1c4ca9e090 Mon Sep 17 00:00:00 2001
From: ORelio <oreliogitantispam.l0gin@spamgourmet.com>
Date: Thu, 5 Mar 2020 21:38:07 +0100
Subject: [PATCH] Fix GetLocation() endianness (#881)

---
 MinecraftClient/Protocol/Handlers/DataTypes.cs | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/MinecraftClient/Protocol/Handlers/DataTypes.cs b/MinecraftClient/Protocol/Handlers/DataTypes.cs
index 9912d308..489eb405 100644
--- a/MinecraftClient/Protocol/Handlers/DataTypes.cs
+++ b/MinecraftClient/Protocol/Handlers/DataTypes.cs
@@ -445,7 +445,7 @@ namespace MinecraftClient.Protocol.Handlers
             if (protocolversion < Protocol18Handler.MC18Version)
             {
                 byte[] length = BitConverter.GetBytes((short)array.Length);
-                Array.Reverse(length);
+                Array.Reverse(length); //Endianness
                 return ConcatBytes(length, array);
             }
             else return ConcatBytes(GetVarInt(array.Length), array);
@@ -464,7 +464,7 @@ namespace MinecraftClient.Protocol.Handlers
         }
 
         /// <summary>
-        /// Get a byte array representing the given location encoded as an unsigned short
+        /// Get a byte array representing the given location encoded as an unsigned long
         /// </summary>
         /// <remarks>
         /// A modulo will be applied if the location is outside the following ranges:
@@ -475,11 +475,14 @@ namespace MinecraftClient.Protocol.Handlers
         /// <returns>Location representation as ulong</returns>
         public byte[] GetLocation(Location location)
         {
+            byte[] locationBytes;
             if (protocolversion >= Protocol18Handler.MC114Version)
             {
-                return BitConverter.GetBytes(((((ulong)location.X) & 0x3FFFFFF) << 38) | ((((ulong)location.Z) & 0x3FFFFFF) << 12) | (((ulong)location.Y) & 0xFFF));
+                locationBytes = BitConverter.GetBytes(((((ulong)location.X) & 0x3FFFFFF) << 38) | ((((ulong)location.Z) & 0x3FFFFFF) << 12) | (((ulong)location.Y) & 0xFFF));
             }
-            else return BitConverter.GetBytes(((((ulong)location.X) & 0x3FFFFFF) << 38) | ((((ulong)location.Y) & 0xFFF) << 26) | (((ulong)location.Z) & 0x3FFFFFF));
+            else locationBytes = BitConverter.GetBytes(((((ulong)location.X) & 0x3FFFFFF) << 38) | ((((ulong)location.Y) & 0xFFF) << 26) | (((ulong)location.Z) & 0x3FFFFFF));
+            Array.Reverse(locationBytes); //Endianness
+            return locationBytes;
         }
 
         /// <summary>