Fix all compilation warnings (CS9107, CS8600, CS8604, CS8618, CS0168, CS0169, CS0649)

- Fix CS9107: Replace lowercase primary constructor parameter refs with
  PascalCase base class properties in 90+ StructuredComponent files
- Fix CS8618: Add null! initializers for late-initialized properties
- Fix CS8600: Use nullable out parameters in World.cs, ChatParser.cs
- Fix CS8604: Add null guard in Compiler.cs, fix null-conditional in McClient.cs
- Fix CS0168: Replace unused variable with discard in DataTypes.cs
- Fix CS0169: Remove unused motionY field from McClient.cs
- Fix CS0649: Remove never-assigned steps field, simplify ClientIsMoving()
- Initialize client/handler with null! to avoid CS8618 cascade

Co-authored-by: milutinke <441903+milutinke@users.noreply.github.com>
Agent-Logs-Url: https://github.com/milutinke/Minecraft-Console-Client/sessions/7fcee1b2-21e2-4457-b01b-5e0a1f07752f

MinecraftClient/Mapping/World.cs

@@ -317,7 +317,7 @@ namespace MinecraftClient.Mapping
 	public static void SetDimension(string name)
 	{
 	    // Try to get the dimension using the name as is
-	    if (dimensionList.TryGetValue(name, out Dimension dimension))
+	    if (dimensionList.TryGetValue(name, out Dimension? dimension))
 	    {
 		curDimension = dimension;
 		return; // Dimension found

MinecraftClient/McClient.cs

@@ -61,14 +61,12 @@ namespace MinecraftClient
         private readonly Lock locationLock = new();
         private bool locationReceived = false;
         private readonly World world = new();
-        private Queue<Location>? steps;
         private Queue<Location>? path;
         private Location location;
         private float? _yaw; // Used for calculation ONLY!!! Doesn't reflect the client yaw
         private float? _pitch; // Used for calculation ONLY!!! Doesn't reflect the client pitch
         private float playerYaw;
         private float playerPitch;
-        private double motionY;
         private readonly PlayerPhysics playerPhysics = new();
         private readonly MovementInput physicsInput = new();
         private bool physicsInitialized = false;
@@ -156,8 +154,8 @@ namespace MinecraftClient
         public void SetCookie(string key, byte[] data) => Cookies[key] = data;
         public void DeleteCookie(string key) => Cookies.Remove(key, out var data);
 
-        TcpClient client;
-        IMinecraftCom handler;
+        TcpClient client = null!;
+        IMinecraftCom handler = null!;
         SessionToken _sessionToken;
         CancellationTokenSource? cmdprompt = null;
         Tuple<Thread, CancellationTokenSource>? timeoutdetector = null;
@@ -213,7 +211,7 @@ namespace MinecraftClient
                 scope.SetTag("MCC Build", Program.BuildInfo is null ? "Debug" : Program.BuildInfo);
                     
                 if (forgeInfo is not null)
-                    scope.SetTag("Forge Version", forgeInfo?.Version.ToString());
+                    scope.SetTag("Forge Version", forgeInfo.Version.ToString());
 
                 scope.Contexts["Server Information"] = new
                 {
@@ -2782,7 +2780,7 @@ namespace MinecraftClient
         /// <returns>true if a movement is currently handled</returns>
         public bool ClientIsMoving()
         {
-            return terrainAndMovementsEnabled && locationReceived && ((steps is not null && steps.Count > 0) || (path is not null && path.Count > 0));
+            return terrainAndMovementsEnabled && locationReceived && path is not null && path.Count > 0;
         }
 
         /// <summary>

MinecraftClient/Protocol/Handlers/DataTypes.cs

@@ -973,7 +973,7 @@ namespace MinecraftClient.Protocol.Handlers
 
                 return data;
             }
-            catch(Exception ex)
+            catch (Exception)
             {
                 return new Dictionary<int, object?>();
             }

MinecraftClient/Protocol/Handlers/StructuredComponents/Components/1_20_6/BundleContentsComponent.cs

@@ -16,7 +16,7 @@ public class BundleContentsComponent(DataTypes dataTypes, ItemPalette itemPalett
 
         for (var i = 0; i < count; i++)
         {
-            var item = DataTypes.ReadNextItemSlot(data, itemPalette);
+            var item = DataTypes.ReadNextItemSlot(data, ItemPalette);
             if (item is not null)
                 Items.Add(item);
         }
@@ -28,7 +28,7 @@ public class BundleContentsComponent(DataTypes dataTypes, ItemPalette itemPalett
         data.AddRange(DataTypes.GetVarInt(Items.Count));
 
         foreach (var item in Items)
-            data.AddRange(DataTypes.GetItemSlot(item, itemPalette));
+            data.AddRange(DataTypes.GetItemSlot(item, ItemPalette));
 
         return new Queue<byte>(data);
     }

MinecraftClient/Protocol/Handlers/StructuredComponents/Components/1_20_6/ChargedProjectilesComponent.cs

@@ -16,7 +16,7 @@ public class ChargedProjectilesComponent(DataTypes dataTypes, ItemPalette itemPa
 
         for (var i = 0; i < count; i++)
         {
-            var item = DataTypes.ReadNextItemSlot(data, itemPalette);
+            var item = DataTypes.ReadNextItemSlot(data, ItemPalette);
             if (item is not null)
                 Items.Add(item);
         }
@@ -28,7 +28,7 @@ public class ChargedProjectilesComponent(DataTypes dataTypes, ItemPalette itemPa
         data.AddRange(DataTypes.GetVarInt(Items.Count));
 
         foreach (var item in Items)
-            data.AddRange(DataTypes.GetItemSlot(item, itemPalette));
+            data.AddRange(DataTypes.GetItemSlot(item, ItemPalette));
 
         return new Queue<byte>(data);
     }

MinecraftClient/Protocol/Handlers/StructuredComponents/Components/1_20_6/ContainerComponent.cs

@@ -22,7 +22,7 @@ public class ContainerComponent(DataTypes dataTypes, ItemPalette itemPalette, Su
         var data = new List<byte>();
         data.AddRange(DataTypes.GetVarInt(Items.Count));
         foreach (var item in Items)
-            data.AddRange(DataTypes.GetItemSlot(item, itemPalette));
+            data.AddRange(DataTypes.GetItemSlot(item, ItemPalette));
             
         return new Queue<byte>(data);
     }

MinecraftClient/Protocol/Handlers/StructuredComponents/Components/Subcomponents/1_20_6/EffectSubComponent.cs

@@ -6,7 +6,7 @@ namespace MinecraftClient.Protocol.Handlers.StructuredComponents.Components.Subc
 
 public class EffectSubComponent(DataTypes dataTypes, SubComponentRegistry subComponentRegistry) : SubComponent(dataTypes, subComponentRegistry)
 {
-    public PotionEffectSubComponent TypeId { get; set; }
+    public PotionEffectSubComponent TypeId { get; set; } = null!;
     public float Probability { get; set; }
     
     protected override void Parse(Queue<byte> data)

MinecraftClient/Protocol/Handlers/StructuredComponents/Components/Subcomponents/1_20_6/PotionEffectSubComponent.cs

@@ -7,7 +7,7 @@ namespace MinecraftClient.Protocol.Handlers.StructuredComponents.Components.Subc
 public class PotionEffectSubComponent(DataTypes dataTypes, SubComponentRegistry subComponentRegistry) : SubComponent(dataTypes, subComponentRegistry)
 {
     public int TypeId { get; set; }
-    public DetailsSubComponent Details { get; set; }
+    public DetailsSubComponent Details { get; set; } = null!;
     
     protected override void Parse(Queue<byte> data)
     {

MinecraftClient/Protocol/Handlers/StructuredComponents/Components/Subcomponents/1_20_6/RuleSubComponent.cs

@@ -6,7 +6,7 @@ namespace MinecraftClient.Protocol.Handlers.StructuredComponents.Components.Subc
 
 public class RuleSubComponent(DataTypes dataTypes, SubComponentRegistry subComponentRegistry) : SubComponent(dataTypes, subComponentRegistry)
 {
-    public BlockSetSubcomponent Blocks { get; set; }
+    public BlockSetSubcomponent Blocks { get; set; } = null!;
     public bool HasSpeed { get; set; }
     public float Speed { get; set; }
     public bool HasCorrectDropForBlocks { get; set; }

MinecraftClient/Protocol/Message/ChatParser.cs

@@ -545,11 +545,11 @@ namespace MinecraftClient.Protocol.Message
                         break;
                     case "translate":
                     {
-                        if (nbt.TryGetValue("translate", out object translate))
+                        if (nbt.TryGetValue("translate", out object? translate))
                         {
                             var translateKey = (string)translate;
                             List<string> translateString = new();
-                            if (nbt.TryGetValue("with", out object withComponent))
+                            if (nbt.TryGetValue("with", out object? withComponent))
                             {
                                 var withs = (object[])withComponent;
                                 for (var i = 0; i < withs.Length; i++)
@@ -574,7 +574,7 @@ namespace MinecraftClient.Protocol.Message
                         break;
                     case "color":
                     {
-                        if (nbt.TryGetValue("color", out object color))
+                        if (nbt.TryGetValue("color", out object? color))
                         {
                             colorCode = Color2tag((string)color);
                         }

MinecraftClient/Scripting/DynamicRun/Builder/Compiler.cs

@@ -82,6 +82,8 @@ namespace MinecraftClient.Scripting.DynamicRun.Builder
             {
                 // Create a temporary file to copy the executable to.
                 var executablePath = Environment.ProcessPath;
+                if (executablePath is null)
+                    throw new InvalidOperationException("Cannot determine the process path for self-contained scripting extraction.");
                 var tempPath = Path.Combine(Path.GetTempPath(), "mcc-scripting");
                 Directory.CreateDirectory(tempPath);