helpy4/Minecraft-Console-Client
1
0
Fork 0
mirror of https://github.com/MCCTeam/Minecraft-Console-Client synced 2025-11-07 17:36:07 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fixed a crash

Browse source 
Fixed a crash when a chat message was received on a server that uses protocol lib and viaversion.
This commit is contained in:
Anon 2024-01-28 21:43:21 +01:00 • committed by GitHub
commit 3bfe5aa855
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 6 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

8
MinecraftClient/Protocol/Handlers/Protocol18.cs
View file

@ -484,6 +484,7 @@ namespace MinecraftClient.Protocol.Handlers
private bool HandlePlayPackets(int packetId, Queue<byte> packetData) private bool HandlePlayPackets(int packetId, Queue<byte> packetData)
{ {
try{
switch (packetPalette.GetIncommingTypeById(packetId)) switch (packetPalette.GetIncommingTypeById(packetId))
{ {
case PacketTypesIn.KeepAlive: // Keep Alive (Play) case PacketTypesIn.KeepAlive: // Keep Alive (Play)
@ -797,7 +798,7 @@ namespace MinecraftClient.Protocol.Handlers
var chatInfo = Json.ParseJson(chatName).Properties; var chatInfo = Json.ParseJson(chatName).Properties;
var senderDisplayName = var senderDisplayName =
(chatInfo.ContainsKey("insertion") ? chatInfo["insertion"] : chatInfo["text"]) (chatInfo.ContainsKey("insertion") ? chatInfo["insertion"] : (chatInfo.ContainsKey("text") ? chatInfo["text"] : ""))
.StringValue; .StringValue;
string? senderTeamName = null; string? senderTeamName = null;
var messageTypeEnum = var messageTypeEnum =
@ -909,7 +910,7 @@ namespace MinecraftClient.Protocol.Handlers
var chatInfo = var chatInfo =
Json.ParseJson(targetName ?? chatName).Properties; Json.ParseJson(targetName ?? chatName).Properties;
var senderDisplayName = var senderDisplayName =
(chatInfo.ContainsKey("insertion") ? chatInfo["insertion"] : chatInfo["text"]) (chatInfo.ContainsKey("insertion") ? chatInfo["insertion"] : (chatInfo.ContainsKey("text") ? chatInfo["text"] : ""))
.StringValue; .StringValue;
string? senderTeamName = null; string? senderTeamName = null;
if (targetName != null && if (targetName != null &&
@ -2570,6 +2571,9 @@ namespace MinecraftClient.Protocol.Handlers
} }
return true; //Packet processed return true; //Packet processed
}catch(Exception exception){
exception.printStackTrace();
}
} }
/// <summary> /// <summary>