From 1a1caec30a6f26129788cce1e004bf090268db63 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Mon, 4 May 2026 11:36:01 +0000 Subject: [PATCH] Polish console chat visibility implementation Agent-Logs-Url: https://github.com/MCCTeam/Minecraft-Console-Client/sessions/159bd460-7950-4afe-9e69-4892220665e1 Co-authored-by: milutinke <441903+milutinke@users.noreply.github.com> --- MinecraftClient/ConsoleIO.cs | 8 +++++--- MinecraftClient/Logger/FileLogLogger.cs | 2 +- MinecraftClient/Logger/FilteredLogger.cs | 2 +- .../Resources/Translations/Translations.Designer.cs | 4 ++-- MinecraftClient/Resources/Translations/Translations.resx | 4 ++-- MinecraftClient/Tui/MainTuiView.cs | 1 + 6 files changed, 12 insertions(+), 9 deletions(-) diff --git a/MinecraftClient/ConsoleIO.cs b/MinecraftClient/ConsoleIO.cs index 246a27d8..2c5a168c 100644 --- a/MinecraftClient/ConsoleIO.cs +++ b/MinecraftClient/ConsoleIO.cs @@ -164,7 +164,7 @@ namespace MinecraftClient /// /// Write a formatted chat line to the console when chat output is enabled. /// - public static void WriteChatLineFormatted(string str, bool acceptnewlines = false, bool? displayTimestamp = null) + public static void WriteChatLineIfVisible(string str, bool acceptnewlines = false, bool? displayTimestamp = null) { if (!ChatVisible) return; @@ -206,11 +206,13 @@ namespace MinecraftClient { Console.Clear(); } - catch (IOException) + catch (IOException ex) { + System.Diagnostics.Debug.WriteLine(ex); } - catch (PlatformNotSupportedException) + catch (PlatformNotSupportedException ex) { + System.Diagnostics.Debug.WriteLine(ex); } return; diff --git a/MinecraftClient/Logger/FileLogLogger.cs b/MinecraftClient/Logger/FileLogLogger.cs index 7cc4972f..53fb9a57 100644 --- a/MinecraftClient/Logger/FileLogLogger.cs +++ b/MinecraftClient/Logger/FileLogLogger.cs @@ -72,7 +72,7 @@ namespace MinecraftClient.Logger { if (ShouldDisplay(FilterChannel.Chat, msg)) { - ConsoleIO.WriteChatLineFormatted(msg); + ConsoleIO.WriteChatLineIfVisible(msg); Save(msg); } else Debug("[Logger] One Chat message filtered: " + msg); diff --git a/MinecraftClient/Logger/FilteredLogger.cs b/MinecraftClient/Logger/FilteredLogger.cs index 03ee06a1..6260c373 100644 --- a/MinecraftClient/Logger/FilteredLogger.cs +++ b/MinecraftClient/Logger/FilteredLogger.cs @@ -81,7 +81,7 @@ namespace MinecraftClient.Logger { if (ShouldDisplay(FilterChannel.Chat, msg)) { - ConsoleIO.WriteChatLineFormatted(msg); + ConsoleIO.WriteChatLineIfVisible(msg); } else Debug("[Logger] One Chat message filtered: " + msg); } diff --git a/MinecraftClient/Resources/Translations/Translations.Designer.cs b/MinecraftClient/Resources/Translations/Translations.Designer.cs index 621afa37..52ec91ae 100644 --- a/MinecraftClient/Resources/Translations/Translations.Designer.cs +++ b/MinecraftClient/Resources/Translations/Translations.Designer.cs @@ -3043,7 +3043,7 @@ namespace MinecraftClient { } /// - /// Looks up a localized string similar to Console chat output is now hidden. + /// Looks up a localized string similar to Console chat output is now hidden.. /// internal static string cmd_console_chat_state_off { get { @@ -3052,7 +3052,7 @@ namespace MinecraftClient { } /// - /// Looks up a localized string similar to Console chat output is now visible. + /// Looks up a localized string similar to Console chat output is now visible.. /// internal static string cmd_console_chat_state_on { get { diff --git a/MinecraftClient/Resources/Translations/Translations.resx b/MinecraftClient/Resources/Translations/Translations.resx index e795cb63..6052e661 100644 --- a/MinecraftClient/Resources/Translations/Translations.resx +++ b/MinecraftClient/Resources/Translations/Translations.resx @@ -1094,10 +1094,10 @@ Change EnableEmoji=false in the settings if the display is confusing. toggle chat visibility in the console. - Console chat output is now hidden + Console chat output is now hidden. - Console chat output is now visible + Console chat output is now visible. clear the console output. diff --git a/MinecraftClient/Tui/MainTuiView.cs b/MinecraftClient/Tui/MainTuiView.cs index d5400d3a..9eda3c62 100644 --- a/MinecraftClient/Tui/MainTuiView.cs +++ b/MinecraftClient/Tui/MainTuiView.cs @@ -272,6 +272,7 @@ namespace MinecraftClient.Tui { _logLines.Clear(); _logControls.Clear(); + ScheduleScrollToEnd(); } private void TrimLog()