2023-03-24 19:46:25 +08:00
|
|
|
using MinecraftClient.Mapping.EntityMetadataPalettes;
|
|
|
|
|
using MinecraftClient.Protocol.Handlers;
|
|
|
|
|
using System;
|
2023-03-23 23:41:41 +01:00
|
|
|
using System.Collections.Generic;
|
|
|
|
|
|
|
|
|
|
namespace MinecraftClient.Mapping;
|
|
|
|
|
|
|
|
|
|
public abstract class EntityMetadataPalette
|
|
|
|
|
{
|
|
|
|
|
public abstract Dictionary<int, EntityMetaDataType> GetEntityMetadataMappingsList();
|
2023-03-24 19:46:25 +08:00
|
|
|
|
|
|
|
|
public EntityMetaDataType GetDataType(int typeId)
|
|
|
|
|
{
|
|
|
|
|
return GetEntityMetadataMappingsList()[typeId];
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
public static EntityMetadataPalette GetPalette(int protocolVersion)
|
|
|
|
|
{
|
2023-06-08 19:27:28 +02:00
|
|
|
return protocolVersion switch
|
|
|
|
|
{
|
|
|
|
|
<= Protocol18Handler.MC_1_8_Version => new EntityMetadataPalette18(), // 1.8
|
|
|
|
|
<= Protocol18Handler.MC_1_12_2_Version => new EntityMetadataPalette1122(), // 1.9 - 1.12.2
|
|
|
|
|
<= Protocol18Handler.MC_1_19_2_Version => new EntityMetadataPalette1191(), // 1.13 - 1.19.2
|
|
|
|
|
<= Protocol18Handler.MC_1_19_3_Version => new EntityMetadataPalette1193(), // 1.19.3
|
fix: add EntityMetadataPalette1206 for correct 1.20.6+ entity metadata parsing
1.20.6 introduced three new EntityDataSerializer types compared to 1.20.4:
- PARTICLES (id 18) - list of particles, inserted after PARTICLE
- WOLF_VARIANT (id 23) - wolf variant holder, inserted after CAT_VARIANT
- ARMADILLO_STATE (id 28) - armadillo state, inserted after SNIFFER_STATE
These insertions shifted subsequent serializer IDs, causing the 1.19.4
palette (EntityMetadataPalette1194) to misidentify metadata types on
1.20.6+ servers. This could lead to incorrect byte consumption and
potential packet parse failures when entities with affected metadata
types (e.g. wolves, armadillos, area effect clouds with particles)
were present.
Changes:
- Add Particles, WolfVariant, ArmadilloState to EntityMetaDataType enum
- Create EntityMetadataPalette1206 with correct 31-entry ID mapping
- Route 1.20.6+ to the new palette in EntityMetadataPalette.GetPalette()
- Add read logic for the three new types in DataTypes.cs
Verified on 1.21.1 vanilla server: cat, wolf, frog, armadillo, painting
entities all spawn without metadata parse errors.
Made-with: Cursor
2026-03-20 01:43:48 +08:00
|
|
|
< Protocol18Handler.MC_1_20_6_Version => new EntityMetadataPalette1194(), // 1.19.4 - 1.20.4
|
2026-03-20 23:51:56 +08:00
|
|
|
<= Protocol18Handler.MC_1_21_4_Version => new EntityMetadataPalette1206(), // 1.20.6 - 1.21.4
|
2026-03-21 13:10:30 +08:00
|
|
|
<= Protocol18Handler.MC_1_21_7_Version => new EntityMetadataPalette1215(), // 1.21.5 - 1.21.7
|
2023-06-08 19:27:28 +02:00
|
|
|
_ => throw new NotImplementedException()
|
|
|
|
|
};
|
2023-03-24 19:46:25 +08:00
|
|
|
}
|
2023-03-23 23:41:41 +01:00
|
|
|
}
|